Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increases gas toxicity across the board. #10571

Merged
merged 1 commit into from Jan 6, 2019

Conversation

alex-gh
Copy link
Contributor

@alex-gh alex-gh commented Jan 1, 2019

What does this PR do:
While working on upping the oxygen damage to Vox I have discovered that toxic gases do a laughable amount of damage. For example you could stay in 25% plasma atmosphere indefinitely and survive by vomiting alone.

This PR increases the toxicity of the gases by a factor of 10.
It also ups the damage Vox take from oxygen, bringing the oxygen toxicity in line with the toxicity of plasma.

A vox will fall into hard crit in about 2 minutes and 20 seconds in the normal atmosphere.

Changelog:
馃啈 uc_guy
balance: Toxic gases now do more damage.
balance: Vox take higher damage from oxygen.
/:cl:

@Spartan6
Copy link
Contributor

Spartan6 commented Jan 1, 2019

Thank fuck.

@KasparoVy
Copy link
Contributor

KasparoVy commented Jan 1, 2019

Thank you very very much. This was busted back in the lung refactor ages ago

This PR addresses #10217 (closed) and resolves this forum post (will be closed).

@Ralta
Copy link
Contributor

Ralta commented Jan 2, 2019

Finally. I don't play Vox as much as I used to, but they should really be taking far more damage for breathing oxygen than they are now; this'll be a good change for that.

As far as general toxicity, how quickly would you pass out from being exposed to, say, plasma with this change?

@alex-gh
Copy link
Contributor Author

alex-gh commented Jan 2, 2019

@Ralta Depends on plasma concentration but there is an upper damage cap of 10 damage/breath. For 20% plasma : same as Vox 2:20.

@Ralta
Copy link
Contributor

Ralta commented Jan 2, 2019

Perfect, thanks for the response @alex-gh - looking forward to this getting merged 馃榿

@Birdtalon
Copy link
Contributor

Does nobody else think a factor of 10 is a bit crazy?

@alex-gh
Copy link
Contributor Author

alex-gh commented Jan 3, 2019

@Birdtalon Like I said, the current damage values are laughable.

Spin up a test server, open a canister of plasma on arrival shuttle, see for yourself.

@Birdtalon
Copy link
Contributor

Yeah just chatted to Spartan on discord about it. Seems fine then from his description.

@marlyn-x86 marlyn-x86 added the Balance This PR will modify how effective something is or isnt label Jan 3, 2019
@variableundefined variableundefined merged commit cbbf8c0 into ParadiseSS13:master Jan 6, 2019
@KasparoVy
Copy link
Contributor

KasparoVy commented Jan 7, 2019

Glorious

If my rig wasn't toast I'd be revelling in oxygen toxicity right this minute

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance This PR will modify how effective something is or isnt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants