New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrapping big objects and welding lockers now takes time #11156
Wrapping big objects and welding lockers now takes time #11156
Conversation
This should probably also apply to welding lockers which IIRC is instant |
Wasn't sure if that got fixed yet or not. I'll include it in this PR as well |
@@ -177,7 +177,9 @@ | |||
var/obj/structure/closet/crate/O = target | |||
if(O.opened) | |||
return | |||
if(use(3)) | |||
if(amount >= 3 && do_after_once(usr, 15, target = target)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You know what I did to the last person who cast usr
when a proc can explicitly pass user
.
馃挘 馃挜
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Max capped their ass off the codebase
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hawt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TBF, relative to the rest of this proc, that's just a small drop in the ocean 馃槃
Thanks for this! |
literally this is my #1 goto method for capturing people... damn. |
That poor, poor PR. It thinks we remember it, but no. Just misguided calls to itself. I mean have you seen the number of references it has? What else is weird is all the merge push requests it gets throughout the years |
What does this PR do:
Makes wrapping a locker and crates take time. No more locker catching cheese.
Guy asked for this and it made sense:
https://nanotrasen.se/forum/topic/15602-wrapping-lockers/
Makes welding lockers take time as well.
Both take 1.5 seconds to do.
Code of the wrapping is a mess but that's not what this PR is about.
Changelog:
馃啈
tweak: Wrapping lockers and crates now takes 1.5 seconds to do
tweak: Welding lockers now takes 1.5 seconds to do
/:cl: