Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrapping big objects and welding lockers now takes time #11156

Merged
merged 4 commits into from Apr 2, 2019

Conversation

farie82
Copy link
Member

@farie82 farie82 commented Mar 28, 2019

What does this PR do:
Makes wrapping a locker and crates take time. No more locker catching cheese.
Guy asked for this and it made sense:
https://nanotrasen.se/forum/topic/15602-wrapping-lockers/

Makes welding lockers take time as well.

Both take 1.5 seconds to do.

Code of the wrapping is a mess but that's not what this PR is about.

Changelog:
馃啈
tweak: Wrapping lockers and crates now takes 1.5 seconds to do
tweak: Welding lockers now takes 1.5 seconds to do
/:cl:

@datlo
Copy link
Contributor

datlo commented Mar 28, 2019

This should probably also apply to welding lockers which IIRC is instant

@farie82
Copy link
Member Author

farie82 commented Mar 28, 2019

This should probably also apply to welding lockers which IIRC is instant

Wasn't sure if that got fixed yet or not. I'll include it in this PR as well

@farie82 farie82 changed the title Wrapping big objects such as lockers now takes time Wrapping big objects and welding lockers now takes time Mar 28, 2019
@@ -177,7 +177,9 @@
var/obj/structure/closet/crate/O = target
if(O.opened)
return
if(use(3))
if(amount >= 3 && do_after_once(usr, 15, target = target))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You know what I did to the last person who cast usr when a proc can explicitly pass user.

馃挘 馃挜

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Max capped their ass off the codebase

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hawt

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBF, relative to the rest of this proc, that's just a small drop in the ocean 馃槃

@SalazarJosh
Copy link

Thanks for this!

@Fox-McCloud Fox-McCloud added the Balance This PR will modify how effective something is or isnt label Mar 31, 2019
@Jazz23
Copy link
Contributor

Jazz23 commented Apr 1, 2019

literally this is my #1 goto method for capturing people... damn.

@taukausanake
Copy link
Contributor

literally this is my (#)1

That poor, poor PR. It thinks we remember it, but no. Just misguided calls to itself. I mean have you seen the number of references it has? What else is weird is all the merge push requests it gets throughout the years

@variableundefined variableundefined merged commit 58f253a into ParadiseSS13:master Apr 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance This PR will modify how effective something is or isnt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants