Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lavaland #11196

Merged
merged 88 commits into from May 31, 2019
Merged

Lavaland #11196

merged 88 commits into from May 31, 2019

Conversation

mvanalphen
Copy link
Contributor

@mvanalphen mvanalphen commented Mar 31, 2019

After laying the foundations like... two years ago, I figured it's high time to make a return and port this over. I've ported over the Lavaland map and a number of ruins (pretty much the biggest ones). These are all entirely up-to-date with /tg/. I've also ported over everything that's on these maps that we didn't yet have and made the necessary changes to the code. These new items are generally speaking also up-to-date, unless porting them over would involve other major refactors. What I haven't done is update existing Lavaland items (although they aren't hugely outdated).

What's next?
I haven't been able to test everything I added, simply because it touches quite a large number of things and there's a lot of stuff. So what needs to happen:

  • Code review, as I haven't gone over everything I've done yet. There's some hacky implementations here and there we need to figure out.
  • Extensive testing, preferably through a test merge.
  • Figure out how we want to balance everything for Paradise.
  • Make sure everything is suited for Paradise: we may need to make adjustments here and there in terms of loot and other things.
  • We'll probably want to remap the Labor Camp and the mining station.
  • Figure out what changes need to be made on the Cyberiad to support Lavaland (i.e. mining vendor).

This is going to conflict out the ass, so we do need to hurry up slightly with this. The diffbot contains all relevant map images.

All credit for Lavaland goes to a large number of people at /tg/. There's too many individuals, but if you'd like your name listed here or in the changelog please let me know and I will add you.

🆑 Ported by Markolie and CornMyCob. Developed by many /tg/ coders
add: The mining asteroid has been replaced with Lavaland.
/🆑

@AffectedArc07
Copy link
Member

mfw me and corn have been working on this for 2 weeeks now and someone else has started

@Spartan6
Copy link
Contributor

*dab

@mvanalphen
Copy link
Contributor Author

Sorry @AffectedArc07, I wasn't aware of that!

@KasparoVy
Copy link
Contributor

By their PRs combined they are Captain Confict

@Spartan6
Copy link
Contributor

I mean, if this is real.

Pics and stuff.

@mvanalphen
Copy link
Contributor Author

It's very real, I've uploaded some images here.

code/__HELPERS/icons.dm Outdated Show resolved Hide resolved
@TDSSS
Copy link
Contributor

TDSSS commented May 7, 2019

What happens if a singulo is created in lavaland? Does it eat through the entire planet and expose the space on the other side or how do the turfs handle that?

@taukausanake
Copy link
Contributor

Now I want to make a singulo on the mining asteroid and see what happens 👀

@mvanalphen
Copy link
Contributor Author

Lavaland tiles are immune to the singularity.

@Couls
Copy link
Contributor

Couls commented May 8, 2019

oh no conflicts!

@mvanalphen
Copy link
Contributor Author

These conflicts are killing me.

…o turfs

# Conflicts:
#	_maps/map_files/Delta/delta.dmm
#	_maps/map_files/MetaStation/MetaStation.v41A.II.dmm
#	_maps/map_files/MetaStation/z4.dmm
#	_maps/map_files/RandomRuins/SpaceRuins/derelict5.dmm
#	_maps/map_files/RandomRuins/SpaceRuins/spacebar.dmm
#	_maps/map_files/RandomZLevels/spacebattle.dmm
#	_maps/map_files/cyberiad/cyberiad.dmm
#	_maps/map_files/cyberiad/z4.dmm
#	_maps/map_files/cyberiad/z6.dmm
#	_maps/map_files/generic/z5.dmm
#	code/__DEFINES/misc.dm
#	code/__HELPERS/unsorted.dm
#	code/game/objects/structures/lattice.dm
#	code/game/turfs/space/space.dm
#	code/modules/mob/mob.dm
#	code/modules/ruins/ruin_areas.dm
#	paradise.dme
@marlyn-x86 marlyn-x86 added Map Edit This PR will modify a map Map Freeze This PR is on hold until a certain map PR goes through, to avoid conflicts labels May 10, 2019
…o turfs

# Conflicts:
#	icons/mob/actions/actions.dmi
#	paradise.dme
…o turfs

# Conflicts:
#	icons/mob/actions/actions.dmi
#	icons/mob/inhands/items_lefthand.dmi
#	icons/mob/inhands/items_righthand.dmi
#	paradise.dme
@mvanalphen
Copy link
Contributor Author

One more conflict and I'll bomb the station.

…o turfs

# Conflicts:
#	icons/mob/feet.dmi
#	paradise.dme
@Couls
Copy link
Contributor

Couls commented May 29, 2019

Image of mark resolving conflicts: https://i.imgflip.com/18rd3t.jpg

EDIT:
image

@taukausanake
Copy link
Contributor

@Couls should have posted the Pipboy face/his avatar over the skull

…o turfs

# Conflicts:
#	icons/obj/vending.dmi
#	paradise.dme
- Survival pod storage being broken when used.
- Wrong wiring on the Syndicate base.
- Added one more oxygen tank to the animal hospital.
- Chasms eating up light atoms.
- Mining satchels not picking up items automatically.
- Releasing the legion/blob mice notifications not having icons.
- Mining gear made orderable at cargo.
@marlyn-x86 marlyn-x86 removed the Map Freeze This PR is on hold until a certain map PR goes through, to avoid conflicts label May 31, 2019
Copy link
Member

@marlyn-x86 marlyn-x86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good enough
There's a couple minor things but we can fix those in post

code/modules/mob/mob.dm Show resolved Hide resolved
code/modules/mob/mob.dm Show resolved Hide resolved
@marlyn-x86
Copy link
Member

Time to get messy

@marlyn-x86 marlyn-x86 merged commit 4fdb80a into ParadiseSS13:master May 31, 2019
@KasparoVy
Copy link
Contributor

KasparoVy commented May 31, 2019

holy shit

Sincerely going to miss space mining but this is absolutely dope.

Great job

new /obj/item/clothing/suit/space/hardsuit/mining(src)
new /obj/item/clothing/head/helmet/space/hardsuit/mining(src)

/obj/item/storage/box/hug
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LMAO

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature This PR is a new addition to the game Map Edit This PR will modify a map
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet