New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DNM] Arrivals ferry! The arrivals shuttle actually carries arrivals now #12045
Conversation
This would prevent space vines and blobs from spawncamping the everloving fuck out of the arrivals shuttle. |
'del: station airlocks no longer bolt when a shuttle departs' Does that mean that the arrival shuttle airlocks can be opened to space when the arrivals shuttle isnt docked? This will lead to SO many spaced and/or gibbed by shuttle civilians and might fuck up arrivals atmos semi regularly which is already a pain in the ass to fix due to how arrivals is mapped. With how our atmos wind works, youre likely just going to get pushed out to space the moment you fuck up and open the airlock. What about mining/engi docks? Are they affected too? Currently the only 'official' ways out of the station at roundstart are cycling airlocks and it should probably stay like that. |
The thing that killed parallax |
The shuttle doesn鈥檛 actually leave quick enough for you to get fastmos鈥檇 out into space but the airlocks won鈥檛 be bolted no, I鈥檒l see what I can do about bringing that feature back |
Shouldnt the bolting the airlocks feature still be in, assuming you didnt just overwrite the file with the TG contents? |
Literally the only thing I really wanted from /TG/. Arrivals ship actually arriving. I am going to miss the hyperspace transit areas when traveling but I think Parallax killed that already |
@taukausanake If its porting the TG shuttle system it means it dynamically creates the shuttle areas instead of having them mapped in, freeing some space on Z2 |
See, that鈥檚 the strange thing. With the new code when ur bolted the doors it seemed to bolt every door on station regardless of ID tag, I was more focused on implementing the system so I removed the bolting in order to get it working |
This actually has a lot of potential for changing the OOC safe haven aspect of Arrivals and I've always wanted this |
The shuttle doors are open in transit, a new player will just walk right out into space They should be bolted closed too |
Lmfao. Welcome to space station 13, enjoy your stay. |
Should most definitely fix the doors not bolting thing for reasons listed above. Otherwise kinda like it~. |
I got a question. This is more of a possible oversight concern. But what about players joining the round as ghost (observe)? |
They should spawn at the center of the station instead |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR will likely take a while before it is actually reviewed due to competing PRs that also conflict with maps.
That鈥檚 no problem, I still have to fix the issue with door airlocks bolting |
What does this PR do:
Port of: tgstation/tgstation#24694 and tgstation/tgstation#19017
Frees up space on z2 by removing all the pre-made transit shuttle zones, instead loads up transit areas dynamically using markers. The arrivals shuttle now docks with the station and carries latejoiners with it.
Images of sprite/map changes (IF APPLICABLE):
http://puu.sh/E7Hg2/0140fce332.mp4
Changelog:
馃啈
add: Arrivals shuttle now docks with the station
del: transit space and transit ports in z2
tweak: transit space and ports are now dynamically loaded based on demand
del: station airlocks no longer bolt when a shuttle departs
/:cl: