[Need Feedback] TG Slaughter Demon Port Remake, THE REGIBBINGING #1387

Aurorablade · 2015-06-25T01:43:32Z

So i did a thing..and it messed up alot of other things..so i remade the
thing..
Adjusted some spans and redid the spawn locs based on the ghostie antag

So a remake of the branch i Effed up at #1323

Ports TG Slaughter Demon by @KorPhaeron tgstation/tgstation#9973 (is it bad i have been stalking this for days to port it?) All credits to him for the concept and more credits i shoved in the file itself.

New side event/antagonist. Simple animal that can use pools of blood as
portals to move around the station. Spooky scary.

-CtrlClick on an adjacent blood pool (or turf with blood on it) to
"enter" (start an infinite duration jaunt
-CtrlClick on a blood pool while jaunted to exit at that pool
-If you're pulling a mob while you enter a pool, the mob gets pulled in
with you, and you devour them, healing yourself
-Night vision

Adds an event (admin only) that spawns one.

Adds wizard item for summoning it. Has objective to kill the wizard (and everyone else).

Bonus additions from me: Crabrender and Clownrender. I also wanted to add a Ponyrender..but i would be lynched.

To do:
What more fluff can i add?
Does anyone want this as a random event?
Anything else to be done/added?

So i did a thing..and it messed up alot of other things..so i remade the thing.. Adjusted some spans and redid the spawn locs based on the ghostie antag

NOTHING TO SEE HERE

Apprently travis need this file...

TheDZD · 2015-06-25T13:52:51Z

Might want to look at tgstation/tgstation#10151.

Aurorablade · 2015-06-25T13:54:53Z

@TheDZD Will do.

fixes as per tgstation/tgstation#10151 Also spread the one per limit to the Scrying orb, Can remove or add to other items as suggested/needed by feedback.

Aurorablade · 2015-06-26T21:37:26Z

So any feedback? Bits of fluff i can add? Make it an event?

Maybe have people explode into another demon and/or a demonic heart inspired by http://www.scp-wiki.net/scp-058 if they eat the heart item? (I know 'why would they do that?!' ....People are odd okay)

Aurorablade · 2015-06-27T20:46:57Z

I am adding in a blood pustile ability kinda copying some things from a blob code.
Things i could use a gentle slap to the head on:
Should i be using another cooldown var instead of shareing with gorethrow?

Its supposed to throw out gibs and blood about every 60 secs, I got it working i think but dunno if its a good method.

Was going to add attack hand code...MEssed it up...>.>

i would LOVE to use the BadFeeling artifact messages but i am unsure how to call that proper.

I was not sure where to put my blob core recolor for the node so i used blood.dmi
YES I KNOW the sprite is a silly recolor..but thats my thing, i recolor/edit sprites..don't ask me to do one from scratch.

I think i am getting a cold so forgive cringe worthy code errors.

blood pustile..ewwwww

…o STILLALOTOFBLOOD

see tgstation/tgstation#10259 only i went with the Observer visability ala Reven

squash!

…o STILLALOTOFBLOOD

Aurorablade · 2015-07-01T00:43:08Z

@Fox-McCloud I was doing a compile to test out my paranoia changes and got the following error, i have not touched these files so i am unsure why its doing it
loading paradise.dme
code\modules\garbage collection\garbage_collector.dm:108:error: proc definition not allowed inside another proc
code\modules\garbage collection\garbage_collector.dm:144:error: unbalanced }
paradise.dmb - 2 errors, 0 warnings

Aurorablade · 2015-07-01T01:20:33Z

OH HI TRAVIS HOW ARE YOU

Aurorablade · 2015-07-01T01:28:18Z

Note i am going to fix the travis errors but i want to get that previous mentioned GC error out of the way so i can ACTUALLY COMPILE AND TEST

maybe....

Aurorablade · 2015-07-01T02:05:14Z

OKAY fixed my issue, Apprently i had to update Byond to the BETA version makes the more you know rainbow

Weee! paranoia works!

Aurorablade · 2015-07-02T18:26:37Z

I am actually pretty happy with where this is unless someone sees a code change in need to make or feels i need make it a random event proper.

The bloodnode code might need some tweaks though..

…o STILLALOTOFBLOOD

one line, i am sure i missed others. Always miss that ONE Debug print.

…o STILLALOTOFBLOOD

urgh

…o STILLALOTOFBLOOD

TheDZD · 2015-08-06T00:28:35Z

Looked over this, looks fine. Awaiting opinion from @Fox-McCloud.

Fox-McCloud · 2015-08-06T03:21:14Z

code/game/gamemodes/antag_spawner.dm

+	var/checking = 0
+
+
+/obj/item/weapon/antag_spawner/slaughter_demon/attack_self(mob/user as mob)


not really sure this should be handled this way--this is a wizard item, so it may be best to handle it just like the revenant does; pull someone and shove them into the slaughter demon; also means you dont' ahve to have the get_candidate_answer stuff.

ghost · 2015-08-06T03:33:56Z

Surely one day this will be merged

Fox-McCloud · 2015-08-06T03:34:03Z

code/modules/mob/living/bloodcrawl.dm

+	icon_state = "innards"
+
+//Gib helperfunc
+/mob/living/proc/GibEat(var/napped)


I have concerns about this; one of the limits on a slaughter demon's power is that he's dependent on existing blood...and this pretty much means that he self-creates blood.

Fox-McCloud · 2015-08-06T03:44:27Z

Aside from the things I addressed...I have some concerns with the custom abilities you added. All of them generate a huge amount of blood....which is the "resource" the slaughter demon depends on....slaughter demon already saounds like it's pretty insanely strong, what with its 200 health and 30 melee damage...I don't think killing people or creating blood will be that difficult for it, to be honest.

ghost · 2015-08-06T04:54:21Z

It actually creates way too much blood as it is simply by dragging bodies around behind it.

Fox-McCloud · 2015-08-06T04:56:13Z

@KorPhaeron

Exactly, which is why, IMO, it doesn't need any of the spells here.

ghost · 2015-08-06T05:12:45Z

code/modules/mob/living/simple_animal/slaughter/bloodnode.dm

@@ -0,0 +1,117 @@
+//yes i did stealfrom blobcode...
+/obj/effect/bloodnode
+	name = "blood pustilue"


Aurorablade · 2015-08-06T05:51:59Z

Commiting changes in a moment..not sure if i need a better player mind check on the antag spawner..Much Sleepy, Many bed, wow falls asleep on keybored

Revert to the orignal TG method of just shoving a player into the daemon on vial break. did the same for the event (i still like using the revenant spawns rather then carp spawns for that, not as disoriniting to me) Added reference to BLOODCRAWL_EAT i missed Devouring now heals more types of damage Removes some gore abilitys...I got overzealous in wanting blood....Keeping the spooky demon head whisper... No don't ask why i called it Pustle...My brain frightens me...

Fox-McCloud · 2015-08-06T20:43:19Z

Whisper was a good inclusion; I never had a problem with that one.

Fox-McCloud · 2015-08-06T23:48:36Z

Probably pretty close to being mergable; requesting someone else review this; potentially @TheDZD or @tigercat2000

TheDZD · 2015-08-07T00:15:56Z

code/game/gamemodes/wizard/artefact.dm

@@ -199,5 +211,5 @@

 /obj/item/weapon/scrying/attack_self(mob/user as mob)
 	user << "\blue You can see...everything!"
-	visible_message("\red <B>[usr] stares into [src], their eyes glazing over.</B>")
+	visible_message("\red <B>[user] stares into [src], their eyes glazing over.</B>")


Would be best to replace the text macro and bold with <span class='danger'>message</span>. Just minor nitpicking though.

yeah i was gonna fix all of them in the file but i saw so many that i think my head exploded...i just changed that one user..then looked all the preexisting stuff on the file....

Aurorablade · 2015-08-07T22:08:21Z

@Fox-McCloud @TheDZD anything else i need to fix/change?

[Need Feedback] TG Slaughter Demon Port Remake, THE REGIBBINGING

Regen1 · 2015-08-07T23:11:37Z

!HAPPENING!

ghost · 2015-08-07T23:19:04Z

Oh wow finally. Steal stands next.

Aurorablade · 2015-08-08T00:06:18Z

@KorPhaeron you mean your guardian spirit thing?

ghost · 2015-08-08T00:08:39Z

Yeah. Also lemme know how demons work out

LETS DO THE GIT WARP AGAIN! LETS DO THE GIT WARP AGAIN!

b642948

So i did a thing..and it messed up alot of other things..so i remade the thing.. Adjusted some spans and redid the spawn locs based on the ghostie antag

Aurorablade changed the title ~~LETS DO THE GIT WARP AGAIN! LETS DO THE GIT WARP AGAIN!~~ [DNM] TG Slaughter Demon Port Remake, THE REGIBBINGING Jun 25, 2015

Fox-McCloud added Do Not Merge This PR must not be merged or closed Feature This PR is a new addition to the game labels Jun 25, 2015

Aurorablade added 2 commits June 24, 2015 21:51

WOOPS

bfc69ab

NOTHING TO SEE HERE

HURRRRRR

134d16b

Apprently travis need this file...

Fixes based on TG pull

ab820df

fixes as per tgstation/tgstation#10151 Also spread the one per limit to the Scrying orb, Can remove or add to other items as suggested/needed by feedback.

Add new ability

ed2a885

blood pustile..ewwwww

Aurorablade changed the title ~~[DNM] TG Slaughter Demon Port Remake, THE REGIBBINGING~~ [DNM][Need Feedback] TG Slaughter Demon Port Remake, THE REGIBBINGING Jun 28, 2015

Aurorablade added 5 commits June 29, 2015 19:31

Merge branch 'master' of https://github.com/ParadiseSS13/Paradise int…

1c583a3

…o STILLALOTOFBLOOD

fixes based on TG PR

2bfe0a1

see tgstation/tgstation#10259 only i went with the Observer visability ala Reven

Paranoia update

9f8467d

Woops updated too soon

e22866c

squash!

Merge branch 'master' of https://github.com/ParadiseSS13/Paradise int…

b7b5cb6

…o STILLALOTOFBLOOD

Untested Maybe Fix

215fbd2

maybe....

Last commit of the night.

93aacc5

Weee! paranoia works!

Aurorablade added 5 commits July 2, 2015 15:57

Merge branch 'master' of https://github.com/ParadiseSS13/Paradise int…

5f44c38

…o STILLALOTOFBLOOD

Remove a debug print

7085935

one line, i am sure i missed others. Always miss that ONE Debug print.

Merge branch 'master' of https://github.com/ParadiseSS13/Paradise int…

372680f

…o STILLALOTOFBLOOD

Odd Merge conflict fix

d987b63

urgh

Merge branch 'master' of https://github.com/ParadiseSS13/Paradise int…

a2d6591

…o STILLALOTOFBLOOD

TheDZD removed the Do Not Merge This PR must not be merged or closed label Aug 6, 2015

Fox-McCloud reviewed Aug 6, 2015
View reviewed changes

ghost reviewed Aug 6, 2015
View reviewed changes

TheDZD reviewed Aug 7, 2015
View reviewed changes

Typo and color macro fix

bec3b6b

TheDZD added a commit that referenced this pull request Aug 7, 2015

Merge pull request #1387 from Aurorablade/STILLALOTOFBLOOD

171c0d2

[Need Feedback] TG Slaughter Demon Port Remake, THE REGIBBINGING

TheDZD merged commit 171c0d2 into ParadiseSS13:master Aug 7, 2015

Aurorablade deleted the STILLALOTOFBLOOD branch February 13, 2016 06:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Need Feedback] TG Slaughter Demon Port Remake, THE REGIBBINGING #1387

[Need Feedback] TG Slaughter Demon Port Remake, THE REGIBBINGING #1387

Aurorablade commented Jun 25, 2015

TheDZD commented Jun 25, 2015

Aurorablade commented Jun 25, 2015

Aurorablade commented Jun 26, 2015

Aurorablade commented Jun 27, 2015

Aurorablade commented Jul 1, 2015

Aurorablade commented Jul 1, 2015

Aurorablade commented Jul 1, 2015

Aurorablade commented Jul 1, 2015

Aurorablade commented Jul 2, 2015

TheDZD commented Aug 6, 2015

Fox-McCloud Aug 6, 2015

ghost commented Aug 6, 2015

Fox-McCloud Aug 6, 2015

Fox-McCloud commented Aug 6, 2015

ghost commented Aug 6, 2015

Fox-McCloud commented Aug 6, 2015

ghost Aug 6, 2015

Aurorablade commented Aug 6, 2015

Fox-McCloud commented Aug 6, 2015

Fox-McCloud commented Aug 6, 2015

TheDZD Aug 7, 2015

Aurorablade Aug 7, 2015

Aurorablade commented Aug 7, 2015

Regen1 commented Aug 7, 2015

ghost commented Aug 7, 2015

Aurorablade commented Aug 8, 2015

ghost commented Aug 8, 2015

		var/checking = 0


		/obj/item/weapon/antag_spawner/slaughter_demon/attack_self(mob/user as mob)

[Need Feedback] TG Slaughter Demon Port Remake, THE REGIBBINGING #1387

[Need Feedback] TG Slaughter Demon Port Remake, THE REGIBBINGING #1387

Conversation

Aurorablade commented Jun 25, 2015

TheDZD commented Jun 25, 2015

Aurorablade commented Jun 25, 2015

Aurorablade commented Jun 26, 2015

Aurorablade commented Jun 27, 2015

Aurorablade commented Jul 1, 2015

Aurorablade commented Jul 1, 2015

Aurorablade commented Jul 1, 2015

Aurorablade commented Jul 1, 2015

Aurorablade commented Jul 2, 2015

TheDZD commented Aug 6, 2015

Fox-McCloud Aug 6, 2015

Choose a reason for hiding this comment

ghost commented Aug 6, 2015

Fox-McCloud Aug 6, 2015

Choose a reason for hiding this comment

Fox-McCloud commented Aug 6, 2015

ghost commented Aug 6, 2015

Fox-McCloud commented Aug 6, 2015

ghost Aug 6, 2015

Choose a reason for hiding this comment

Aurorablade commented Aug 6, 2015

Fox-McCloud commented Aug 6, 2015

Fox-McCloud commented Aug 6, 2015

TheDZD Aug 7, 2015

Choose a reason for hiding this comment

Aurorablade Aug 7, 2015

Choose a reason for hiding this comment

Aurorablade commented Aug 7, 2015

Regen1 commented Aug 7, 2015

ghost commented Aug 7, 2015

Aurorablade commented Aug 8, 2015

ghost commented Aug 8, 2015