New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gives better feedback when control or alt-clicking pressure pumps, volume pumps, etc. #15404
Merged
variableundefined
merged 3 commits into
ParadiseSS13:master
from
SteelSlayer:atmos-alt-control-click
Jul 27, 2021
Merged
Gives better feedback when control or alt-clicking pressure pumps, volume pumps, etc. #15404
variableundefined
merged 3 commits into
ParadiseSS13:master
from
SteelSlayer:atmos-alt-control-click
Jul 27, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dearmochi
reviewed
Jan 31, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one thing
dearmochi
approved these changes
Jan 31, 2021
AffectedArc07
approved these changes
Feb 1, 2021
SteelSlayer
force-pushed
the
atmos-alt-control-click
branch
from
February 20, 2021 00:00
b45098a
to
99ba598
Compare
SteelSlayer
force-pushed
the
atmos-alt-control-click
branch
from
June 13, 2021 15:29
99ba598
to
6a72225
Compare
SabreML
reviewed
Jul 24, 2021
code/modules/atmospherics/machinery/components/binary_devices/pump.dm
Outdated
Show resolved
Hide resolved
code/modules/atmospherics/machinery/components/binary_devices/volume_pump.dm
Outdated
Show resolved
Hide resolved
code/modules/atmospherics/machinery/components/trinary_devices/filter.dm
Outdated
Show resolved
Hide resolved
code/modules/atmospherics/machinery/components/trinary_devices/mixer.dm
Outdated
Show resolved
Hide resolved
variableundefined
suggested changes
Jul 26, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DM on discord when deconflicted with link for merge.
SteelSlayer
force-pushed
the
atmos-alt-control-click
branch
from
July 27, 2021 00:08
51dcfc6
to
d5ecfc3
Compare
variableundefined
approved these changes
Jul 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This PR Do
var/on
andvar/target_pressure
all over the place. Made these base vars on/obj/machinery/atmospherics
Why It's Good For The Game
Better, and correct feedback to players.
Fixes #15400
Changelog
馃啈
tweak: Removes the "It's anchored to the floor!" messages when you control-click on pressure pumps, volume pumps, gas filters, and gas mixers
tweak: Adds feedback messages when alt or control-clicking on pressure pumps, volume pumps, gas filters, and gas mixers
/:cl: