Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gives better feedback when control or alt-clicking pressure pumps, volume pumps, etc. #15404

Merged

Conversation

SteelSlayer
Copy link
Member

What Does This PR Do

  1. Removes the "It's anchored to the floor!" messages when you control-click on pressure pumps, volume pumps, gas filters, and gas mixers. Adds a new chat message for this: "You toggle X on/off".
  2. Adds a new chat message for alt-clicking these devices: "You set the target pressure of X to maximum."
  3. Small refactor of some variables. I had to unfortunately change a bunch of files because tons of atmos machinery were declaring var/on and var/target_pressure all over the place. Made these base vars on /obj/machinery/atmospherics

Why It's Good For The Game

Better, and correct feedback to players.

Fixes #15400

Changelog

馃啈
tweak: Removes the "It's anchored to the floor!" messages when you control-click on pressure pumps, volume pumps, gas filters, and gas mixers
tweak: Adds feedback messages when alt or control-clicking on pressure pumps, volume pumps, gas filters, and gas mixers
/:cl:

Copy link
Contributor

@dearmochi dearmochi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one thing

code/ATMOSPHERICS/components/trinary_devices/mixer.dm Outdated Show resolved Hide resolved
@AffectedArc07 AffectedArc07 added the Fix This PR will fix an issue in the game label Feb 1, 2021
@github-actions github-actions bot added the Merge Conflict This PR is merge conflicted label Feb 16, 2021
@github-actions github-actions bot removed the Merge Conflict This PR is merge conflicted label Feb 20, 2021
@github-actions github-actions bot added the Merge Conflict This PR is merge conflicted label Jul 26, 2021
Copy link
Contributor

@variableundefined variableundefined left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DM on discord when deconflicted with link for merge.

@github-actions github-actions bot removed the Merge Conflict This PR is merge conflicted label Jul 27, 2021
@variableundefined variableundefined merged commit 1cc930a into ParadiseSS13:master Jul 27, 2021
@SteelSlayer SteelSlayer deleted the atmos-alt-control-click branch July 27, 2021 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix This PR will fix an issue in the game
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ctrl+Clicking and alt+Clicking atmos pumps doesn't give correct feedback
5 participants