Ports TG glowshrooms

code/game/objects/effects/glowshroom.dm

@@ -9,11 +9,23 @@
 	icon = 'icons/obj/lighting.dmi'
 	icon_state = "glowshroom" //replaced in New
 	layer = ABOVE_NORMAL_TURF_LAYER
-	max_integrity = 30
-	var/delay = 1200
-	var/floor = 0
+	/// Time interval between glowshroom "spreads"
+	var/delay_spread = 2 MINUTES
+	/// Time interval between glowshroom decay checks
+	var/delay_decay = 30 SECONDS
+	/// Boolean to indicate if the shroom is on the floor/wall
+	var/floor = FALSE
+	/// Mushroom generation number
 	var/generation = 1
-	var/spreadIntoAdjacentChance = 60
+	/// Chance to spread into adjacent tiles (0-100)
+	var/adjacent_spread_chance = 75
+	/// If we fail to spread this many times we stop trying to spread
+	var/max_failed_spreads = 5
+	/// Turfs where the glowshroom cannot spread to
+	var/static/list/blacklisted_glowshroom_turfs = typecacheof(list(
+	/turf/simulated/floor/plating/lava,
+	/turf/simulated/floor/beach/water))
+	/// Internal seed of the glowshroom, stats are stored here
 	var/obj/item/seeds/myseed = /obj/item/seeds/glowshroom
 
 /obj/structure/glowshroom/glowcap
@@ -35,29 +47,33 @@
 	. = ..()
 	. += "This is a [generation]\th generation [name]!"
 
-/obj/structure/glowshroom/Destroy()
-	QDEL_NULL(myseed)
-	return ..()
+/**
+  *	Creates a new glowshroom structure.
+  *
+  * Arguments:
+  * * newseed - Seed of the shroom
+  * * mutate_stats - If the plant needs to mutate their stats
+  * * spread - If the plant is a result of spreading, reduce its stats
+  */
 
-/obj/structure/glowshroom/New(loc, obj/item/seeds/newseed, mutate_stats)
-	..()
+/obj/structure/glowshroom/Initialize(mapload, obj/item/seeds/newseed, mutate_stats, spread)
+	. = ..()
 	if(newseed)
 		myseed = newseed.Copy()
 		myseed.forceMove(src)
 	else
 		myseed = new myseed(src)
 	if(mutate_stats) //baby mushrooms have different stats :3
-		myseed.adjust_potency(rand(-3,6))
-		myseed.adjust_yield(rand(-1,2))
-		myseed.adjust_production(rand(-3,6))
-		myseed.adjust_endurance(rand(-3,6))
-	delay = delay - myseed.production * 100 //So the delay goes DOWN with better stats instead of up. :I
-	obj_integrity = myseed.endurance
-	max_integrity = myseed.endurance
+		myseed.adjust_potency(rand(-4, 3))
+		myseed.adjust_yield(rand(-3, 2))
+		myseed.adjust_production(rand(-3, 3))
+		myseed.endurance = clamp(myseed.endurance + rand(-3, 2), 0, 100) // adjust_endurance has a min value of 10, need to edit directly
+	if(myseed.production >= 1) //In case production is varedited to -1 or less which would cause unlimited or negative delay.
+		delay_spread = delay_spread - (11 - myseed.production) * 100 //Because lower production speed stat gives faster production speed, which should give faster mushroom spread. Range 200-1100 deciseconds.
 	if(myseed.get_gene(/datum/plant_gene/trait/glow))
 		var/datum/plant_gene/trait/glow/G = myseed.get_gene(/datum/plant_gene/trait/glow)
 		set_light(G.glow_range(myseed), G.glow_power(myseed), G.glow_color)
-	setDir(CalcDir())
+	setDir(calc_dir())
 	var/base_icon_state = initial(icon_state)
 	if(!floor)
 		switch(dir) //offset to make it be on the wall rather than on the floor
@@ -73,60 +89,83 @@
 	else //if on the floor, glowshroom on-floor sprite
 		icon_state = "[base_icon_state]f"
 
-	addtimer(CALLBACK(src, .proc/Spread), delay)
+	addtimer(CALLBACK(src, .proc/Spread), delay_spread, TIMER_UNIQUE|TIMER_NO_HASH_WAIT)
+	addtimer(CALLBACK(src, .proc/Decay), delay_decay, TIMER_UNIQUE|TIMER_NO_HASH_WAIT)	// Start decaying the plant
 
 /obj/structure/glowshroom/proc/Spread()
+	//We could be deleted at any point and the timers might not be cleaned up
+	if(QDELETED(src))
+		return
 	var/turf/ownturf = get_turf(src)
 	var/shrooms_planted = 0
-	for(var/i in 1 to myseed.yield)
-		if(prob(1/(generation * generation) * 100))//This formula gives you diminishing returns based on generation. 100% with 1st gen, decreasing to 25%, 11%, 6, 4, 2...
-			var/list/possibleLocs = list()
-			var/spreadsIntoAdjacent = FALSE
-
-			if(prob(spreadIntoAdjacentChance))
-				spreadsIntoAdjacent = TRUE
-
-			for(var/turf/simulated/floor/earth in view(3,src))
-				if(!ownturf.CanAtmosPass(earth))
-					continue
-				if(spreadsIntoAdjacent || !locate(/obj/structure/glowshroom) in view(1,earth))
-					possibleLocs += earth
-				CHECK_TICK
+	var/list/possible_locs = list()
+	//Lets collect a list of possible viewable turfs BEFORE we iterate for yield so we don't call view multiple
+	//times when there's no real chance of the viewable range changing, really you could do this once on item
+	//spawn and most people probably would not notice.
+	for(var/turf/simulated/floor/earth in view(3, src))
+		if(is_type_in_typecache(earth, blacklisted_glowshroom_turfs))
+			continue
+		if(!ownturf.CanAtmosPass(earth))
+			continue
+		possible_locs += earth
 
-			if(!possibleLocs.len)
+	//Lets not even try to spawn again if somehow we have ZERO possible locations
+	if(!possible_locs.len)
+		return
+	for(var/i in 1 to myseed.yield)
+		var/chance_stats = ((myseed.potency + myseed.endurance * 2) * 0.2) // Chance of generating a new mushroom based on stats
+		var/chance_generation = (100 / (generation * generation)) // This formula gives you diminishing returns based on generation. 100% with 1st gen, decreasing to 25%, 11%, 6, 4, 2...
+
+		// Whatever is the higher chance we use it (this is really stupid as the diminishing returns are effectively pointless???)
+		if(prob(max(chance_stats, chance_generation)))
+			var/spread_to_adjacent = prob(adjacent_spread_chance)
+			var/turf/new_loc = null
+			//Try three random locations to spawn before giving up tradeoff
+			//between running view(1, earth) on every single collected possibleLoc
+			//and failing to spread if we get 3 bad picks, which should only be a problem
+			//if there's a lot of glow shroom clustered about
+			for(var/potato in 1 to 3)
+				var/turf/possible_loc = pick(possible_locs)
+				if(spread_to_adjacent || !locate(/obj/structure/glowshroom) in view(1,possible_loc))
+					new_loc = possible_loc
+					break
+			//We failed to find any location, skip trying to yield
+			if(new_loc == null)
 				break
-
-			var/turf/newLoc = pick(possibleLocs)
-
-			var/shroomCount = 0 //hacky
-			var/placeCount = 1
-			for(var/obj/structure/glowshroom/shroom in newLoc)
-				shroomCount++
-			for(var/wallDir in GLOB.cardinal)
-				var/turf/isWall = get_step(newLoc,wallDir)
-				if(isWall.density)
-					placeCount++
-			if(shroomCount >= placeCount)
+			var/shroom_count = 0 //hacky
+			var/place_count = 1
+			for(var/obj/structure/glowshroom/shroom in new_loc)
+				shroom_count++
+			for(var/wall_dir in GLOB.cardinal)
+				var/turf/is_wall = get_step(new_loc, wall_dir)
+				if(is_wall.density)
+					place_count++
+			if(shroom_count >= place_count)
 				continue
 
-			var/obj/structure/glowshroom/child = new type(newLoc, myseed, TRUE)
+			Decay(TRUE, 2) // Decay before spawning new mushrooms to reduce their endurance
+			if(QDELETED(src))	//Decay can end us
+				return
+			var/obj/structure/glowshroom/child = new type(new_loc, myseed, TRUE, TRUE)
 			child.generation = generation + 1
 			shrooms_planted++
 
-			CHECK_TICK
-		else
-			shrooms_planted++ //if we failed due to generation, don't try to plant one later
-	if(shrooms_planted < myseed.yield) //if we didn't get all possible shrooms planted, try again later
-		myseed.yield -= shrooms_planted
-		addtimer(CALLBACK(src, .proc/Spread), delay)
+	if(!shrooms_planted)
+		max_failed_spreads--
 
-/obj/structure/glowshroom/proc/CalcDir(turf/location = loc)
+	//if we didn't get all possible shrooms planted or we haven't failed to spread at least 5 times then try to spread again later
+	if((shrooms_planted <= myseed.yield) && (max_failed_spreads >= 0))
+		myseed.adjust_yield(-shrooms_planted)
+		//Lets make this a unique hash
+		addtimer(CALLBACK(src, .proc/Spread), delay_spread, TIMER_UNIQUE|TIMER_NO_HASH_WAIT)
+
+/obj/structure/glowshroom/proc/calc_dir(turf/location = loc)
 	var/direction = 16
 
-	for(var/wallDir in GLOB.cardinal)
-		var/turf/newTurf = get_step(location,wallDir)
-		if(newTurf.density)
-			direction |= wallDir
+	for(var/wall_dir in GLOB.cardinal)
+		var/turf/new_turf = get_step(location,wall_dir)
+		if(new_turf.density)
+			direction |= wall_dir
 
 	for(var/obj/structure/glowshroom/shroom in location)
 		if(shroom == src)
@@ -136,22 +175,40 @@
 		else
 			direction &= ~shroom.dir
 
-	var/list/dirList = list()
+	var/list/dir_list = list()
 
 	for(var/i=1,i<=16,i <<= 1)
 		if(direction & i)
-			dirList += i
+			dir_list += i
 
-	if(dirList.len)
-		var/newDir = pick(dirList)
-		if(newDir == 16)
+	if(dir_list.len)
+		var/new_dir = pick(dir_list)
+		if(new_dir == 16)
 			floor = 1
-			newDir = 1
-		return newDir
+			new_dir = 1
+		return new_dir
 
 	floor = 1
 	return 1
 
+/**
+  * Causes the glowshroom to decay by decreasing its endurance.
+  *
+  * Arguments:
+  * * spread - Boolean to indicate if the decay is due to spreading or natural decay.
+  * * amount - Amount of endurance to be reduced due to spread decay.
+  */
+/obj/structure/glowshroom/proc/Decay(spread, amount)
+	if(spread) // Decay due to spread
+		myseed.endurance -= amount
+	else // Timed decay
+		myseed.endurance -= 1
+		if(myseed.endurance > 0)
+			addtimer(CALLBACK(src, .proc/Decay), delay_decay, TIMER_UNIQUE|TIMER_NO_HASH_WAIT) // Recall decay timer
+			return
+	if(myseed.endurance < 1) // Plant is gone
+		qdel(src)
+
 /obj/structure/glowshroom/play_attack_sound(damage_amount, damage_type = BRUTE, damage_flag = 0)
 	if(damage_type == BURN && damage_amount)
 		playsound(src.loc, 'sound/items/welder.ogg', 100, TRUE)
@@ -167,3 +224,8 @@
 	var/obj/effect/decal/cleanable/molten_object/I = new (get_turf(src))
 	I.desc = "Looks like this was \an [src] some time ago."
 	qdel(src)
+
+/obj/structure/glowshroom/attackby(obj/item/I, mob/living/user, params)
+	if(istype(I, /obj/item/plant_analyzer))
+		return myseed.attackby(I, user, params) // Hacky I guess
+	return ..() // Attack normally