Forcibly Enable Hardware-Accelerated Graphics #1690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They're forced on after a delay in client/New(), rather than Login(), to minimize how often they occur and cause flickering.
|
This will only make it flicker for the person who's logging in, correct? |
|
Yep, it changes their client-side settings. In local testing, the setting gets flicked on before the world finishes loading, so it may not even be noticeable most of the time. It's definitely visible if done in Login, though. |
|
Ok, great; just as long as it's a one-time thing and has minimal impact. |
Fox-McCloud
added a commit
that referenced
this pull request
Aug 11, 2015
Forcibly Enable Hardware-Accelerated Graphics
PsiOmegaDelta
added a commit
to PsiOmegaDelta/Baystation12
that referenced
this pull request
Aug 11, 2015
Most likely also fixes the hickup where BYOND still rending lights are blobs of light despite having hardware acceleration enabled. Ports ParadiseSS13/Paradise#1690. Fixes Baystation12#10147 as much as it can be fixed I believe.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lighting system we use requires hardware-accelerated graphics to be enabled; if they aren't, the lighting overlays appear as opaque blocks, covering their tile completely. This has, for some time now, resulted in players having to ask what's up with the colored squares, and get told to enable hardware acceleration.
Turns out, you can just force clients to turn it on. This PR forces it on a half second after a client connects.
Due to BYOND quirkiness, simply turning it on doesn't always work, but it does if you turn it off first, so that's what this does. This causes the lighting overlays to flicker for a brief moment, so I do it in client/New(), instead of Login() (which seems to be the recommend place to do it), so they won't flicker every time a player moves into a new mob. This seems to work fine with a short delay.