Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wryn removal v2 #19112

Merged
merged 4 commits into from Sep 24, 2022
Merged

Wryn removal v2 #19112

merged 4 commits into from Sep 24, 2022

Conversation

AffectedArc07
Copy link
Member

@AffectedArc07 AffectedArc07 commented Sep 19, 2022

Preamble

Before any of you even think to type Improve, dont remove, let me raise you the following.
image

These were added back in 2015. That means there have been more than 7 years for people to improve these and make them playable.


"But AA people were working on these"

Yes. were.
image

If the only holdup on your project is sprites, and said sprites havn't materialised in over a year and a half of time, then its safe to say the project isn't really in progress anymore, and has fallen through.


If any of you want to critique this PR, bring actual, constructive criticism to the table. Don't just spout buzzword sentences such as Improve, dont remove, otherwise I (and everyone else) will brush your comment off as part of the frothing masses.

What Does This PR Do

Revives #15472

Why It's Good For The Game

Cleanup of technical debt.

Testing

I launched the server.

Changelog

N/A, not user facing

@AffectedArc07 AffectedArc07 added the Revert/Feature Removal This PR reverts another PR, is removing another feature we already have label Sep 19, 2022
@ParadiseSS13-Bot ParadiseSS13-Bot added the -Status: Awaiting approval This PR is waiting for approval internally label Sep 19, 2022
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting merge This PR is ready for merge and removed -Status: Awaiting approval This PR is waiting for approval internally labels Sep 22, 2022
@hal9000PR hal9000PR merged commit 34927f0 into ParadiseSS13:master Sep 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting merge This PR is ready for merge Revert/Feature Removal This PR reverts another PR, is removing another feature we already have
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants