Progress bars #1919
Merged
Progress bars #1919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit does the following: - Ports progress bars from -tg- (tgstation/tgstation#9921) - Refactors wall attackby code to make it 100% less insane; Instead of manually checking every little thing, it uses do_after, consequentially, making the new progress bars affect dealing with walls as well. Wall code makes a tiger sad.
TheDZD
added
Feature
|
Someone remind me to add the progress bar to the lightning bolt spell as per tgstation/tgstation#10578/ once this goes through. EDIT: Cannot |
|
Yay. 👍 (even if the colons make me scream). Glad to finally see this show up. |
|
👍 |
1 similar comment
|
👍 |
|
Hell yeah 👍 |
|
👍 |
1 similar comment
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tgstation/tgstation#9921
@Iamgoofball
Progress bars!
This commit does the following:
manually checking every little thing, it uses do_after,
consequentially, making the new progress bars affect dealing with walls
as well.
For coders: Do_mob and Do_after have been entirely replaced by -tg-'s versions, which are slightly different. Also, whoever ported revenants, passing too many arguments to a proc should really runtime.
Most notably, do_after now requires a named variable to be specified,
target, which determines where the progress bar will show up. It also requires that the target does not change it's location at any point during the do_after.