Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes stray pixels on multiple hardsuits #20316

Closed
wants to merge 1 commit into from

Conversation

Tortoise-Dakota
Copy link

What Does This PR Do

This PR deletes some random stray pixels from hardsuits in player's hands.

Why It's Good For The Game

Removes annoying pixels that show up over top of player models.

Images of changes

https://i.imgur.com/qNmVMPU.png
https://i.imgur.com/ON9EaP4.png
https://i.imgur.com/2bbukqe.png

Testing

Tested in game, gets rid of those pesky pixels

Changelog

馃啈
fix: Fixed in_hand hardsuits, making them no longer have floating pixels
/:cl:

@ParadiseSS13-Bot ParadiseSS13-Bot added the On Hold Its gonna be a while before this is reviewed label Jan 29, 2023
@ParadiseSS13-Bot
Copy link
Contributor

Your PR has been put on hold as your GitHub account is not linked to a Paradise forums account.

Please link your account at https://www.paradisestation.org/forum/custom/link_github_account.php

Headcoders may ignore this in specific circumstances (Minor fix PR, trusted contributor from another codebase, anything at their discretion)

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally Sprites This PR modifies the game sprites labels Jan 29, 2023
@Bm0n
Copy link
Contributor

Bm0n commented Jan 30, 2023

Note only a few actually fit wrong, namely the clown, mine, wizard and atmos tech hardsuits. The rest fit perfectly fine
image

@Tortoise-Dakota
Copy link
Author

Tortoise-Dakota commented Jan 30, 2023

Note only a few actually fit wrong, namely the clown, mine, wizard and atmos tech hardsuits. The rest fit perfectly fine

Okay, then maybe the issue that Im seeing is specific to certain species? Particularly on vulps, I'll see that the CE's hardsuit will show over top of the tail. Maybe there's something with the layering if that's the case.

@Bm0n
Copy link
Contributor

Bm0n commented Jan 31, 2023

Okay, then maybe the issue that Im seeing is specific to certain species? Particularly on vulps, I'll see that the CE's hardsuit will show over top of the tail. Maybe there's something with the layering if that's the case.

Huh yeah, I think I see what you mean. Appears to be a layering issue with the tail layer and in-hand layer.

Going to need to mess with the layers to fix it.

@Tortoise-Dakota
Copy link
Author

Huh yeah, I think I see what you mean. Appears to be a layering issue with the tail layer and in-hand layer.

Going to need to mess with the layers to fix it.

I'll put this on hold for now then, as its not a sprite issue necessarily. I'll look into the layering issue (though im still very new to coding so it's probably best if someone more competent looks at it other than me)

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting review This PR is awaiting review from the review team and removed -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally labels Feb 1, 2023
Copy link
Member

@S34NW S34NW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any update on this?

@hal9000PR
Copy link
Member

No response from author in 3 weeks. Feel free to reopen with changes requested

@hal9000PR hal9000PR closed this Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting review This PR is awaiting review from the review team On Hold Its gonna be a while before this is reviewed Sprites This PR modifies the game sprites
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants