Gives shadow demons a new spell, Darklight #20510
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ParadiseSS13-Bot
added
-Status: Awaiting type assignment
Sirryan2002
added
the
Requires Wiki Update
ParadiseSS13-Bot
added
-Status: Awaiting approval
hal9000PR
added
the
Balance
ParadiseSS13-Bot
added
-Status: Awaiting review
GDNgit
reviewed
Mar 1, 2023
| summon_type = list(/obj/structure/darklight) | ||
|
|
||
| /obj/effect/proc_holder/spell/aoe/conjure/build/darklight/can_cast(mob/living/simple_animal/demon/shadow/user, charge_check = TRUE, show_message = FALSE) | ||
| if(user.darklight_charges <= 0) // should never go less than 0 but let's just be safe |
There was a problem hiding this comment.
you may just want to do darklight_charges < 1 here if byond does something stupid
GDNgit
reviewed
Mar 1, 2023
| return TRUE | ||
|
|
||
| /obj/effect/proc_holder/spell/aoe/conjure/build/darklight/cast(list/targets, mob/living/simple_animal/demon/shadow/user) | ||
| . = ..() |
There was a problem hiding this comment.
minor thing but you can just do return ..() after you reduce darklight charges
ParadiseSS13-Bot
added
-Status: Awaiting approval
|
The alternative PR I've made seems to be favored more than this one so I'll close this to focus on that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This PR Do
Shadow Demons are given a new spell called Darklight which summons a pylon that projects darkness, similar to the Umbrae full-power spell. This fixed pylon can be destroyed, but gives the Demon an area of relative safety allowing it to hold ground. The Darklight spell requires a charge to use, the demon starts with no charges but gains one by "Gouging" a dead humanoid, specifically one that has a ckey attached to it (so it's a dead player, not a bunch of dead monkeys). They can only gouge a creature once.
Why It's Good For The Game
Shadow Demons are cool conceptually but their actual gameplay falls a bit flat with them being so squishy and having no real reward for actually killing people, unlike slaughter demons who heal off kills and other midrounds who directly benefit. This spell would allow them to take and hold ground after killing people, which should allow the antagonist to be at least a bit more interesting.
Images of changes
Testing
See above.
Changelog
馃啈
add: Added a new spell for Shadow Demons, Darklight
/:cl: