New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Makes *deathgasp less snowflakey #2212
Conversation
the base monkey type needs this message: "lets out a faint chimper as it collapses and stops moving..." |
One minute. |
@@ -84,6 +84,9 @@ | |||
var/virus_immune | |||
var/can_revive_by_healing // Determines whether or not this species can be revived by simply healing them | |||
|
|||
//Death vars. | |||
var/death_message = "seizes up and falls limp, their eyes dead and lifeless..." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seizes up and falls limp, \his eyes dead and lifeless...
would be better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, thanks for pointing that out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually no clue if that would work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll test to make sure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code\modules\mob\living\carbon\human\species\species.dm:88:error: "seizes up and falls limp, \his eyes dead and lifeless...": macro \his requires preceeding expression
Apparently not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well shit. Guess it has to be "their" then.
Perfect, 👍 |
Awesome. If nobody else sees any mistakes, this is good to go after the 24 hour mark. |
For Tajaran, '[name] lets out a waning death rattle as they succumb to their injuries.' I'll add more as I try to figure them out |
I think tajaran are fine really. |
Plotron gave me a neat one for Kidan. |
I figured since tajarans are analoguous with cat-people it'd make sense to give them a death-rattle (if you've ever had a cat for long enough you know what I mean) but w/e, was just le idea |
Eh, this can be merged right now, and if we get a bunch of decent death messages for species I can add it later. |
Makes *deathgasp less snowflakey
After fucking around with the code for half an hour, I de-snowflaked my original *deathgasp code idea, based on @SamCroswell 's suggestion to turn it into a variable and poking around Baystation's code.
Tested and works.
Changes nothing gamewise, IPC's still give the same message that I gave them in the prior PR.
@Iamgoofball look better to you?