Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes *deathgasp less snowflakey #2212

Merged
merged 4 commits into from Sep 30, 2015
Merged

Makes *deathgasp less snowflakey #2212

merged 4 commits into from Sep 30, 2015

Conversation

Spacemanspark
Copy link
Contributor

After fucking around with the code for half an hour, I de-snowflaked my original *deathgasp code idea, based on @SamCroswell 's suggestion to turn it into a variable and poking around Baystation's code.
Tested and works.
Changes nothing gamewise, IPC's still give the same message that I gave them in the prior PR.
@Iamgoofball look better to you?

@Fox-McCloud
Copy link
Member

the base monkey type needs this message:

"lets out a faint chimper as it collapses and stops moving..."

@Spacemanspark
Copy link
Contributor Author

One minute.

@@ -84,6 +84,9 @@
var/virus_immune
var/can_revive_by_healing // Determines whether or not this species can be revived by simply healing them

//Death vars.
var/death_message = "seizes up and falls limp, their eyes dead and lifeless..."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seizes up and falls limp, \his eyes dead and lifeless...

would be better.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, thanks for pointing that out.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually no clue if that would work

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll test to make sure.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code\modules\mob\living\carbon\human\species\species.dm:88:error: "seizes up and falls limp, \his eyes dead and lifeless...": macro \his requires preceeding expression
Apparently not.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well shit. Guess it has to be "their" then.

@mvanalphen mvanalphen added the Refactor This PR will clean up the code but have the same ingame outcome label Sep 28, 2015
@Iamgoofball
Copy link
Contributor

Perfect, 👍

@Spacemanspark
Copy link
Contributor Author

Awesome. If nobody else sees any mistakes, this is good to go after the 24 hour mark.
Before this is merged, anyone want me to stick in some (reasonable/ non-snowflake ["The Vulpakanin swishes it's tail before succumbing to the world of death!" or something similar is going to get you smacked in the face.]) unique death messages for other species? May as well.

@KasparoVy
Copy link
Contributor

For Tajaran, '[name] lets out a waning death rattle as they succumb to their injuries.'
For Vulpkanin, '[name]utters a choked whine before becoming still, tail twitching once.'

I'll add more as I try to figure them out

@tigercat2000
Copy link
Contributor

I think tajaran are fine really.

@Spacemanspark
Copy link
Contributor Author

Plotron gave me a neat one for Kidan.
"The Kidan goes limp, their antennae twitching briefly before stopping entirely..."
And @SamCroswell threw out "Skrell McTentacle face warbles violently before their hair tentacles fall limp..."

@KasparoVy
Copy link
Contributor

I figured since tajarans are analoguous with cat-people it'd make sense to give them a death-rattle (if you've ever had a cat for long enough you know what I mean) but w/e, was just le idea

@Spacemanspark
Copy link
Contributor Author

Eh, this can be merged right now, and if we get a bunch of decent death messages for species I can add it later.

mvanalphen added a commit that referenced this pull request Sep 30, 2015
Makes *deathgasp less snowflakey
@mvanalphen mvanalphen merged commit f10fd6e into ParadiseSS13:master Sep 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Refactor This PR will clean up the code but have the same ingame outcome
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants