New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fethas Carnival of Horrors part 1.5: Swarmers #2325
Conversation
Merge conflict EXTREAME FIX
It looks like the self-repair function only patches up brute damage. Is burn damage meant to stick on these mobs? |
Well i know they aren't supposed to be fire immune. i didn't really thing about it since that the way it is on TG..however it the burn damage is felt to be a big issue i can certainly add in repairing it. |
I realease a swarmer a day on github until this is merged.
releases a swamer on get hub |
@@ -325,6 +325,15 @@ Class Procs: | |||
/obj/machinery/CouldNotUseTopic(var/mob/user) | |||
usr.unset_machine() | |||
|
|||
/obj/machinery/proc/dropContents()//putting for swarmers, occupent code commented out, someone can use later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any particular reason for the occupant code being commented out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
occupant isn't a machine level var on baycode
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah it was in the TG PR for swarmers, I can remove it utterly.
Sorry it took so long for a maintainer to actually look at this. That said, I pointed out anything that looked odd or broken that I could find, a few comments are questions because I'm not certain of the functionality. |
releases another swarmer..evil laugh |
Sorry I haven't looked at this, @Aurorablade I've been distracted by performance fixes of late ;w; |
off topic but hey @tigercat2000 were you still planning on doing that meat spike port? |
harm_intent_damage = 5 | ||
minbodytemp = 0 | ||
maxbodytemp = 500 | ||
unsuitable_atmos_damage = 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't forget to define the atmos damage(s)
Don't forget the 30->40% chance to drop things for the girders ex_act() level 3. also stool/ex_act() from 50 to70% for level 2---and 5 to 50 for level 3 (and making both spawn a sheet of metal). May want to check out the projectile fixes for simple animals here: tgstation/tgstation#11589 |
..() | ||
|
||
/obj/item/unactivated_swarmer/Topic(href, href_list) | ||
if(href_list["ghostjoin"]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The topic parent chain really shouldn't ever be broken.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tigercat2000 suggested fix there?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Include the standard parent chain-
/Topic(href, href_list)
if(..())
return 1
put in fixy fixes to fix the things |
releases another swarmer |
made changes.
Reviewed TG simple animal.dm, made changes based on feedback, mainly in the adjustbruteloss and adjustfireloss. Attack Threshold main diffrence is i am using a damagetype switch and some suggestions from @tigercat2000 |
I think once that's addressed, this can probably be merged. |
visible_message("<span class='warning'>[src] looks unharmed from the damage.</span>") | ||
else | ||
adjustBruteLoss(damage) | ||
updatehealth()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one too many parenthesis.
opps...fixed. |
Is probably good to go. Requesting review by @TheDZD |
Looks good. |
Fethas Carnival of Horrors part 1.5: Swarmers
Merge conflict EXTREAME FIX. Rmake of #2256
Notifying @Fox-McCloud @tigercat2000
ports swarmers https://github.com/tgstation/-tg-station/pull/11382/files https://github.com/tgstation/-tg-station/pull/11589/files and https://github.com/tgstation/-tg-station/pull/11757/files