Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TGUI] Input List #23281

Merged
merged 10 commits into from
Nov 24, 2023
Merged

[TGUI] Input List #23281

merged 10 commits into from
Nov 24, 2023

Conversation

AyIong
Copy link
Contributor

@AyIong AyIong commented Nov 16, 2023

What Does This PR Do

Mostly ports - tgstation/tgstation#56065
However, autofocus has also been ported and the design has been changed as well

Why It's Good For The Game

Search in the holopad, closes - https://github.com/orgs/ParadiseSS13/projects/4/views/1?pane=issue&itemId=38641742 ?
More beautiful windows, and the possibility of making others so in the future

Images of changes

ifjiSKC503

dreamseeker_OpkKKWrF7y

Testing

Blowed myself
image

Changelog

馃啈
add: "Holocall", "Bar Sign" and "Drop Bomb" now have TGUI choice menu with search
/:cl:

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally TGUI This PR modifies TGUI, will conflict labels Nov 16, 2023
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting review This PR is awaiting review from the review team and removed -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally labels Nov 22, 2023
Copy link
Contributor

@Contrabang Contrabang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excited for this, heres my review

code/modules/tgui/modules/tgui_input_list.dm Outdated Show resolved Hide resolved
code/modules/tgui/modules/tgui_input_list.dm Outdated Show resolved Hide resolved
code/modules/tgui/modules/tgui_input_list.dm Outdated Show resolved Hide resolved
code/modules/tgui/modules/tgui_input_list.dm Outdated Show resolved Hide resolved
code/modules/tgui/modules/tgui_input_list.dm Outdated Show resolved Hide resolved
code/modules/tgui/modules/tgui_input_list.dm Outdated Show resolved Hide resolved
code/modules/tgui/modules/tgui_input_list.dm Outdated Show resolved Hide resolved
code/modules/tgui/modules/tgui_input_list.dm Outdated Show resolved Hide resolved
tgui/packages/tgui/interfaces/ListInput.js Outdated Show resolved Hide resolved
tgui/packages/tgui/interfaces/ListInput.js Outdated Show resolved Hide resolved
@AyIong
Copy link
Contributor Author

AyIong commented Nov 22, 2023

Done
And thanks for review

Copy link
Contributor

@Contrabang Contrabang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting merge This PR is ready for merge and removed -Status: Awaiting review This PR is awaiting review from the review team labels Nov 23, 2023
Oyu07 pushed a commit to Oyu07/Paradise that referenced this pull request Jan 2, 2024
* TGUI Input List

* Formatting

* TGUI re-build

* Holopad & Drop Bomb

* Update tgui.bundle.js

* if

* linter

* Mistake

* TGUI input - Barsign

* Review changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting merge This PR is ready for merge TGUI This PR modifies TGUI, will conflict
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants