TGUIv4 - Core backend updates, TGchat, Asset cache updates #23726

S34NW · 2024-01-05T17:05:36Z

What Does This PR Do

Compilation of the TGUIv4 upgrade project so far:
https://github.com/orgs/ParadiseSS13/projects/5/views/1
Key points:

Adds TGchat, a modern and seriously improved browser to replace goonchat.
- Tab support with selectable "sources" of messages.
- Jukebox feature present but not supported by DM code yet.
- TGchat and BYOND share light/dark modes, chosen in TGchat settings, they can no longer be separately chosen.
- Reliability layer implemented, so BYOND can't silently eat messages anymore.
Adds support for TS and TSX files.
Adds smart asset caching, with CDN support for asset hosting.
Updates core TGUI backend, including changes to the TGUI window API.
- Breaking changes: You can no longer set window x and y values in DM, this must now be done in JS/TS.
- Window pooling, the first TGUI window you open will open as normal, but will be extremely faster following that.
Node requirements bumped to 20 for people who build TGUI, due to updates to backend tooling.
Dependencies updated.
Support targeted at IE11, this means users with OS' older than Windows 7 Service Pack 1 (not inclusive) will no longer be able to properly play on paradise, as TGUI will be broken for them.

Second part of the project is still outstanding, that will come later and adds:

TGUI stat panels
TGUI say menu
Jukebox support

Why It's Good For The Game

TGUIv3, our current version, was replaced by TGUIv4 a mere two weeks after we ported it in 2020, so it is literally almost 4 years old.
TGUIv4 changes how assets work with TGUI, so you should no longer get blank TGUI screens due to asset corruption.
Goonchat is terrible and old and outdated.

Images of changes

TGUI itself has a massive array of small changes to how it looks, impossible to list them all here

TGchat is a bit easier, this is with the settings menu open.

Testing

Many screams to the sky by project members.

Current known outstanding issues from TM:
#23760

Changelog

🆑 S34NW, Aylong, Burza, cdui, DGamerL, Gaxeer, stylemistake, many other TG coders
add: TGchat replaces goonchat
tweak: TGUI windows will now re-open quickly after the first window is opened
fix: Fixed BYOND eating chat messages silently
fix: Fixed TGUI whitescreen issue
/:cl:

* tgui4.0 * bugfix for un-interaction * fix for input not resetting on close * NTOS restore * fix all interfaces having scrollbars, fix colours * bundle update * dep bumps * bumps the deps as much as possible * button regression fix * TGUI test map rev 1 * fix theme and some component regression * fix login screen regression * fixes regression with uplink cart * bundle * fix regressions * fix the input issue, again * regression fixes, stylesheet edition, hash restore * fixes GPS BSOD * draggable control regression * dev server dep regression * byondUI regression fix * section regression fix * fix secure storage weirdness * Fixed mining vendor scrolling * Arthri review pass 1 * mining vendor double-scroll * fix for RPD, AirAlarm, and Radio * arthri review pass 2 * arthri review pass 3 * sanitize var setting, fix colours, delete unused file * adds CI to branch * god damn AI making random changes * I should remember to compile when changes are made * fixes scrollbar issues * fix camera console, fix flexGrow for sections * CI fix * nanomap fix * Update code/modules/atmospherics/machinery/airalarm.dm * restore margin * style semicolon

* Initial commit * Transferring the remaining windows to JS * Resizing part 1 * Resizing part 2 * Some reverts and polish * Forgot that * undeployed nuke window size --------- Co-authored-by: Aylong <alexanderkitsa@gmail.com>

* First state fixes * Removes "force_open"

…o TGUIv4

* Reduced Logging Changes * setSharedState early return for non-interactive UI * TGUI version bump to 4.1 * Fix sending updates for non-interactive UIs * Scalablue UI Stylesheet Changes * CSS Tgui Bundle * JavaScript TGUI Style Changes * Update tgui/packages/tgui/styles/base.scss Co-authored-by: Aylong <69762909+Aylong220@users.noreply.github.com> * Additional changes to Input and Button scalability * TGUI logging proc update * Indentation fix for logging proc * Update code/__HELPERS/_logging.dm Co-authored-by: S34N <12197162+S34NW@users.noreply.github.com> * Additional log_tgui changes --------- Co-authored-by: Aylong <69762909+Aylong220@users.noreply.github.com> Co-authored-by: S34N <12197162+S34NW@users.noreply.github.com>

…up assets (#23585) * feat: add smart asset cache, add CDN support for assets, properly group assets * fix: make tgui actually work * fix: keeping local name for `tgui.bundle.js` and `tgui.bundle.css` for debug and dev server functioning * fix: make `fontawesome` assets finally work * fix: make proper identation for `if` * fix: add `resolveAsset` to `NanoMap.js` * refactor: update `claw_game` and `chess` to new asset framework * refactor/tweak: don't use string concatenation for browser `content` and `head_content`, use list instead. Don't use `common.css` for paper UI, keep local name for stamp image assets, replace hard ref of browser to `atom` (rare case) to `UID` * refactor: remove redundant debug logs * refactor: remove space betwee `if` and `(` * refactor: remove one more redundant log, properly reload UI resources * rafactor: change names of asset files * fix: adjust existing UIs to properly use assets * fix: properly pass args to to `onclose` proc * Update code/modules/asset_cache/transports/asset_transport.dm Co-authored-by: S34N <12197162+S34NW@users.noreply.github.com> * Update code/modules/asset_cache/transports/asset_transport.dm Co-authored-by: S34N <12197162+S34NW@users.noreply.github.com> --------- Co-authored-by: S34N <12197162+S34NW@users.noreply.github.com>

@Gaxeer

* tgchat * Little cleanup * Refactor Asset Delivery (Part 2) * Little tweaks * fix code styling issues * fix file name duplications * Browser window options fix @Gaxeer * transfer valve fixes * yarn berry initial * vsc tasks * yarn berry working * node 20 * fix dev server (lol wrong yarn) * bloody regressions * fixes that damn scrolltracking bug * Some tweaks and flexGrow deletions It still doesn't work as it should, which makes me nervous * remove unneeded deps * 514 regression fix * change stuff to not conflict with other servers * name it as requested --------- Co-authored-by: S34N <12197162+S34NW@users.noreply.github.com>

…23677) * Stack & UI's Refactor Almost final, polish required Stack & UI's Refactor (Part 1) Stack & UI's Refactor (Part 2) Stack & UI's Refactor (Part 3) * Prettier Maybe bad * ClearChat & some tweaks * Adds a Chat Reliability Layer tgstation/tgstation#79479 * Fix chat BSOD tgstation/tgstation#79821 * WebPack 5 (Didn't work) I hate this shit * Yarn 3.6.4 * make it all work * revert snowflake fix * Stories * adds TS support * re-enable test and prettier * update yarn sdk's * Fix some box regression * ping/reply * Fixes regressions and some things * Zebra and Fix chat button transfer +rebuild * make VSC use the proper local typescript lib * Popper Tooltips tgstation/tgstation#58980 * Popper Tooltips performancy fixes * Dropdown v2 tgstation/tgstation#75164 Without Icon.tsx * BB test map * run build --------- Co-authored-by: S34N <12197162+S34NW@users.noreply.github.com>

* Codeword highlighting for TGUIv4 * null safeties * Apply suggestions from code review Co-authored-by: DGamerL <108773801+DGamerL@users.noreply.github.com> --------- Co-authored-by: DGamerL <108773801+DGamerL@users.noreply.github.com>

…ixes (#23722) * TGUI 4.3 fixes Newscaster fix + inline-blocks * Be gone Box * Mod Chat -> Mentor Chat * Some warning filters * Rebuild * Delete tgui-common.bundle.js * please work * try it like this * 4.3.1 * 4.3.2 * fix * i forgot to build * 4.4.0 * give me more diff details please so I can fix you * its not binary pls git * test without svgs * removes an un-needed SVG file * inlined SVGs test * fix code styling * comment these --------- Co-authored-by: S34N <12197162+S34NW@users.noreply.github.com>

* Initial commit * bundle rebuild * Fixes Radio Sizing * Updates Radio sizing to fix wrapping issues * fix dev server --------- Co-authored-by: S34N <12197162+S34NW@users.noreply.github.com>

* Enable Format On Save for VSCode * Re-enable and fix no-undef --------- Co-authored-by: Arthri <41360489+a@users.noreply.github.com>

Sirryan2002

first few files

code/__DEFINES/misc_defines.dm

code/__HELPERS/type2type.dm

code/__HELPERS/assets.dm

code/controllers/subsystem/SSchat.dm

code/controllers/subsystem/SSping.dm

Sirryan2002

158/781 files

code/controllers/subsystem/SSticker.dm

code/controllers/subsystem/non_firing/SSassets.dm

code/datums/browser.dm

code/game/machinery/autolathe.dm

code/modules/asset_cache/asset_cache_client.dm

code/modules/asset_cache/asset_cache_item.dm

code/modules/asset_cache/asset_list.dm

Sirryan2002

255 / 781 files

code/controllers/subsystem/SStgui.dm

code/modules/asset_cache/transports/asset_transport.dm

code/modules/asset_cache/transports/webroot_transport.dm

code/modules/atmospherics/machinery/airalarm.dm

icons/obj/chemical.dmi

tgui/.gitignore

* Little themes tweaks * NTOS chat theme * Update tgui-panel.bundle.js * Capitalize themes * Paradise theme v1.0 * Little StationTraitsPanel cleanup * Update member_content.dmi * NoCapitalize * Rebuild * Delete Paradise.scss * Create paradise.scss * Forgot * Rewritten Security Records Console For Jesus fucking christ... * Vending and Wires sizes tweaks * ThermoMachine * Syndicate Theme * Little darker * Rewritten Medical Records Console * PDA Nanobank fix * Syndicate Theme Darker * Rebuild TGUI * Wires section grow fix

icons/paradise.png

warriorstar-orion

The TM speaks for itself, all I can really find are nits, but haven't moved onto the JS yet.

warriorstar-orion · 2024-01-21T00:12:21Z

code/controllers/subsystem/non_firing/SSchangelog.dm

+	return GLOB.always_state
+
+/datum/controller/subsystem/changelog/ui_interact(mob/user, datum/tgui/ui = null)
+	ui = SStgui.try_update_ui(user, src, ui)


This SStgui.try_update_ui, if(!ui), ui = new, ui.open() dance shows up a lot. While there's some subtle differences between implementations I feel like this could be generalized.

Can you clarify? You want to roll this behaviour into the base declaration and cut down on the repeated stuff?

code/__HELPERS/assets.dm

code/__HELPERS/iconprocs.dm

code/controllers/configuration/sections/asset_cache_configuration.dm

code/controllers/subsystem/SSchat.dm

code/controllers/subsystem/SSping.dm

code/modules/client/client_procs.dm

code/datums/wires/wires.dm

code/modules/asset_cache/assets/asset_chem_master.dm

* Fixes ERT Manager silenced message function * Adjusts progress bar on ExosuitFabricator * Sets Dropdown selected to align left * Removes the use of self_state select interfaces * Exosuit Fabricator style adjustments * fix sextractor UI * remove empty tochat string * fix human air alarm interactions * fix modals * add F12/IEChooser --------- Co-authored-by: S34N <12197162+S34NW@users.noreply.github.com>

farie82

There are probably more improvements to be made. But lets get this merged to drop the freeze.

## Что этот PR делает Даже не пытайтесь открыть изменённые файлы, это пиздец... ## Почему это хорошо для игры TGUI 4.4 - ParadiseSS13#23726 ## Тестирование Был тестмерж на оффах Был тестмерж у нас ## Changelog :cl: S34NW, Aylong, Burza, cdui, DGamerL, Gaxeer, stylemistake, и другие TG кодеры add: TGUI 4.4, TGchat, Умный кэш ассетов, перелопачивание тонны интерфейсов и куча сумасшедней работы в коллабе с оффами. Теперь все открытые интерфейсы будут открываться мгновенно (или почти мгновенно если интерфейс тяжёлый), белое окно должно быть только в том случае, если вы открываете интерфейс впервые, и то не факт что оно будет. wip: Мы знаем что хайлайты (подсветка текста) в чате не работают с кириллицей, к сожалению, быстрого фикса нет, терпим. /:cl:

S34NW and others added 29 commits December 10, 2023 22:12

TGUIv4 - Moves TGUI Window Sizing from DM to JS (#23524)

48973c7

* Initial commit * Transferring the remaining windows to JS * Resizing part 1 * Resizing part 2 * Some reverts and polish * Forgot that * undeployed nuke window size --------- Co-authored-by: Aylong <alexanderkitsa@gmail.com>

Merge branch 'master' into TGUIv4

469815b

Merge remote-tracking branch 'upstream/master' into TGUIv4

8d74a21

TGUIv4: Remove force_open (#23537)

26ac920

* First state fixes * Removes "force_open"

Merge remote-tracking branch 'upstream/master' into TGUIv4

7a79597

Merge branch 'TGUIv4' of https://github.com/ParadiseSS13/Paradise int…

9893c2b

…o TGUIv4

Merge remote-tracking branch 'upstream/master' into TGUIv4

5b1a767

dev server hotfix (#23584)

4f724a7

ui_interact object constructor argument check (#23594)

5570c1a

Merge remote-tracking branch 'upstream/master' into TGUIv4

6822c4f

Merge branch 'master' into TGUIv4

8d3e922

revert test_TGUI map addition

f1e37d5

Merge remote-tracking branch 'upstream/master' into TGUIv4

64e69f9

we moved these

4293772

change test values

3098bc1

ignore scss files

b2cf432

change hash function

1bbcb1f

TGUIv4 - updates standalone build tooling (#23721)

e480236

swap xxhash64 for md4

1499231

remove hash function

4b29e56

remove old file

f19a45c

TGUIv4 - Removes resizable and improves drag code (#23719)

633ed8d

* Initial commit * bundle rebuild * Fixes Radio Sizing * Updates Radio sizing to fix wrapping issues * fix dev server --------- Co-authored-by: S34N <12197162+S34NW@users.noreply.github.com>

ParadiseSS13-Bot added the -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally label Jan 5, 2024

Arthri and others added 7 commits January 14, 2024 15:07

Reenable no-undef rule. Enable Format On Save for VSCode (#23803)

79aff05

* Enable Format On Save for VSCode * Re-enable and fix no-undef --------- Co-authored-by: Arthri <41360489+a@users.noreply.github.com>

pda scanner message improvements

3321754

fix mentor/admin PMs being sent to the "unsorted" category

8481575

fix garbled custom vote messages

031dec6

moves cyborg analyser to use chatboxes

f705c8b

Merge remote-tracking branch 'upstream/master' into TGUIv4

dabe33f

fixes regression

c9dccf1

SteelSlayer removed the Merge Conflict This PR is merge conflicted label Jan 14, 2024

Sirryan2002 reviewed Jan 16, 2024

View reviewed changes

Sirryan2002 reviewed Jan 18, 2024

View reviewed changes

S34NW and others added 2 commits January 19, 2024 13:47

Prevent F5 reload

f292073

AffectedArc07 reviewed Jan 20, 2024

View reviewed changes

icons/paradise.png Outdated Show resolved Hide resolved

warriorstar-orion suggested changes Jan 21, 2024

View reviewed changes

S34NW and others added 7 commits January 21, 2024 10:14

fixes the enshittified paradise icon

f5dc86e

Sirryan+Warrior reviews

5dc2725

bloody define comments

136c408

comment correction

da8a468

unprivate these

518e5eb

errant . begone (how did this not cause a compiler error)

af215f9

farie82 approved these changes Jan 21, 2024

View reviewed changes

farie82 merged commit 22fbd9a into master Jan 21, 2024
11 checks passed

AyIong mentioned this pull request Jan 21, 2024

Merge Upstream 21.01.2024 ss220club/Paradise-SS220#926

Merged

Contrabang mentioned this pull request Feb 6, 2024

Traitor codeword runtime #19584

Closed

S34NW deleted the TGUIv4 branch March 5, 2024 12:36

FunnyMan3595 mentioned this pull request Mar 7, 2024

Make the Changelog button change color when unread. #24483

Merged

Dimach mentioned this pull request Apr 28, 2024

server: port tgui4 from paradise ss220-space/Paradise#4981

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

TGUIv4 - Core backend updates, TGchat, Asset cache updates #23726

TGUIv4 - Core backend updates, TGchat, Asset cache updates #23726

S34NW commented Jan 5, 2024 •

edited

Sirryan2002 left a comment

Sirryan2002 left a comment

Sirryan2002 left a comment

warriorstar-orion left a comment

warriorstar-orion Jan 21, 2024

S34NW Jan 21, 2024

farie82 left a comment

TGUIv4 - Core backend updates, TGchat, Asset cache updates #23726

TGUIv4 - Core backend updates, TGchat, Asset cache updates #23726

Conversation

S34NW commented Jan 5, 2024 • edited

What Does This PR Do

Why It's Good For The Game

Images of changes

Testing

Changelog

Sirryan2002 left a comment

Choose a reason for hiding this comment

Sirryan2002 left a comment

Choose a reason for hiding this comment

Sirryan2002 left a comment

Choose a reason for hiding this comment

warriorstar-orion left a comment

Choose a reason for hiding this comment

warriorstar-orion Jan 21, 2024

Choose a reason for hiding this comment

S34NW Jan 21, 2024

Choose a reason for hiding this comment

farie82 left a comment

Choose a reason for hiding this comment

S34NW commented Jan 5, 2024 •

edited