Better species suicide support

[Tastyfish]

This was originally to address species that couldn't commit suicide due to NO_BREATHE (it's not just IPC's!), but turned into a refactor/cleanup of the suicide verb. Then, I decided to let the species datum change the open-hand suicide messages.

• Fixes IPCs can't kill themselves #3452
• suicide also acknowledges the config's damage threshold settings and the person's max health now.

🆑
bugfix: Species that don't breathe can kill themselves now!
rscadd: Suicide messages are now catered to your species.
/:cl:

[Tastyfish]

Making this thread for further suggestions for the suicide flavor messages. I guess don't merge this until that thread's become overloaded or gone stale and I add the extra suggestions.

[KasparoVy]

These messages are hilarious and fitting, I wouldn't change it personally hahaha

[VampyrBytes]

Hi @Tastyfish I was going to fix this this morning, beat me to it :) I was going to take it a step further and have a species.suicide verb to allow full customisation of how they died - as an example, IPC's were going to 'turn themselves into spare parts' then cycle through detaching all their external organs. Up to you whether you want to stick with this or go down that route.

One tip. You don't need to copy pasta the default ones into each species - you've set them in species where you created the var, so unless it's changed all the ones further down will already have them :)

[Tastyfish]

@VampyrBytes The ones that look nearly the same have thumbs replaced with claws 😉, didn't want to clog things up with a way to not copypaste those few cases.

Incidentally, I also almost added a species.suicide() proc, but decided against that, since suiciding is just supposed to put you into hard crit, although interestingly, slimes dump liquid just from the sheer damage, and killing yourself with a lot of items does make IPC's fall apart violently, due to the damage multipliers.

[VampyrBytes]

Ah sorry, my bad, didn't look close enough 😊
And yes, you're right about it just meant to be hard crit, was focused too much on fun ways to kill them 😉
I guess it would still be possible through a suicide check in species.handle_death() but that might be going a bit far 😉

[Dumbdumn5]

As a reference to everybody's favorite book of ultimate logic that makes no sense. I demand that all IPCs, much like Marvin, have a suicide message of turning themselves off.

[TheDZD]

What. This is genius.