Refactors eating and drinking

[VampyrBytes]

No more need for 4(!) lots of code dealing with eating and drinking, carbon mobs now have eat proc that handles it and takes a reagent_container/food object and the user
Pills are now a child of food.
Kitchen utensils now create a food item identical to the original with enough reagents taken from it for one mouthful.
The only gameplay changes are related to messages and add consistency (eg you now get the message related to how hungry you are when eating off kitchen utensils)
Fixed some relative pathing

If I've missed anywhere that deals with eating let me know and I'll factor it in

[tigercat2000]

@VampyrBytes Travis is working fine, you didn't update metastation with the new paths.

[VampyrBytes]

Ah right, thanks @tigercat2000

[Tastyfish]

Check the awaystation maps that we use (listeningoutpost, moonoutpost19, undergroundoutpost45) as well.

[Iamgoofball]

Pills are now a child of food.

uhhh

this means patches use food code

[VampyrBytes]

Yeah, I know... I thought the same, then I looked at what they were doing, which was using the pill eating code anyway.

Sounds wrong but works well

[Fox-McCloud]

@VampyrBytes

Before I review this, what thing(s) are changed, exactly? (from a mechanics standpoint).

[VampyrBytes]

There's only 2 new mechanics.
When you picked up food with a kitchen utensil before it just transferred a bite's amount of the reagents from the target food to the fork which were then transferred to the mob when the utensil was used to eat off. Now it creates a new instance of that type of food, removes all the reagents from it and then puts a bite's amount of the reagents from the old one into the new one. The new one is what is passed into the eat proc when the utensil is used.

The other new one is food items having a consume_sound var with the sound to play when it's consumed (if !null), rather than them being hard coded into the procs, which was done for the eating and drinking sounds, and has the side effect of allowing for a specific food to have a specific sound played if someone wanted that (explosion sound on drinking a syndicate bomb anyone? 😉)

Where before there was stuff done in if(human) clauses, it's now done through overriding. All the other mechanics were taken from one or more of the existing methods and just made to work together. Other than that it was just cleaning up stuff.... breaking the big procs up so each proc is focussed on one thing, which can then be overridden, or use another one based on an if, changing colour macros into spans, using visible_message rather than for loops and removing relative paths

Think that pretty much covers everything I did 😃

[VampyrBytes]

@Fox-McCloud
Anything else you need to know before review?

[marlyn-x86]

What is the purpose of this spawn?

[VampyrBytes]

@Crazylemon64
That's a good question. It was in the originals, and I wasn't 100% about taking it out. I'll be glad if I can take it out though, as I had to put in spawns to counteract it when the items were finished, otherwise they got deleted before the reagents were transferred

[Fox-McCloud]

Anything else you need to know before review?

Can't think of anything, at the moment.

[Fox-McCloud]

just waiting for: #2903 to be merged in.

[VampyrBytes]

No worries, I don't want to cause @Aurorablade any more merge conflicts either.

[Fox-McCloud]

Merge conflicts

[VampyrBytes]

Messed up resolving them (which turned out to be a good thing), so putting up a new PR