Ports Tg Simple Vehicle Framework #4119
Conversation
| /obj/vehicle/janicart/examine(mob/user) | ||
| ..() | ||
| if(floorbuffer) | ||
| user << "It has been upgraded with a floor buffer." |
There was a problem hiding this comment.
to_chat(user, "It has been upgraded with a floor buffer.")
|
Damn son, those speeders look REAL good. Future space motorcycles ftw, so mint. |
| generic_pixel_x = 0 | ||
| generic_pixel_y = 4 | ||
| vehicle_move_delay = 1 | ||
| var/static/image/carcover = null |
There was a problem hiding this comment.
seriously what does static do
There was a problem hiding this comment.
no idea..i could remove it if needed....
There was a problem hiding this comment.
http://www.byond.com/forum/?post=137782#comment936991
Assuming the post can be trusted (which I don't doubt) in this case it means that all instances of this (sub)type will share the same carcover image.
The good part is that you'll only ever have one instance of this image, no matter how many cars there are.
The bad part is, should the image change it'll affect all cars (but this can be worked around by having a second non-static var for custom image situations).
There was a problem hiding this comment.
it's semi-synonymous with /global
it also has the quirk that you can access /static vars from a typepath WITHOUT using initial()
ie: the usual
var/obj/item/sword/I = /obj/item/sword
world << initial(I.attackpower)
would be
var/obj/item/sword/I = /obj/item/sword
world << I.attackpower
But yes the main usage here was indeed so that only one version of the image ever needs to exist for all atvs, it's a good idea to do it for other types that will look the same too.
There was a problem hiding this comment.
Basically, BYOND's static keyword works surprisingly similar to how it does in other languages such as C++, C#, Java, etc.
|
You murdered the cargo train? D: But I like the cargo train! I want to have a trail of everythings. Cargo has lost all purpose if the train is gone for good! You can't make it work with this by any chance? I'm serious when I say it should be kept and actually used |
| anchored = 0 | ||
|
|
||
| /obj/structure/stool/bed/amb_trolley/MouseDrop(obj/over_object as obj) | ||
| ..() |
There was a problem hiding this comment.
@Fox-McCloud sorry :( its kinda placeholderisque anyway...i am tying to think of how the attaching the bed to the ambulance is gonna work..so its changeable..
There was a problem hiding this comment.
Well, it's not a huge deal, to be honest.
The ambulance driver can just carry around a roller bed with him and pull that like how janitors pull around the janitorial cart--same thing, effectively.
There was a problem hiding this comment.
If I can leave a comment, having played a paramedic a lot, I would GREATLY prefer the way the janitor cart works. The clip-attach system is such a pain in the ass. Please go with the janitor system, Aurorablade.
|
Make sure people on these things are actually impacted by projectiles. |
|
@Fox-McCloud gotcha, i know one bit in the turret part runtimed one me and i had to change. |
Fox-McCloud
added
Feature
| //add ambulance bed hookup here | ||
| ..() | ||
|
|
||
| /obj/vehicle/ambulance/RunOver(var/mob/living/carbon/human/H) |
There was a problem hiding this comment.
Let this die, IMO. It's annoying that an emergency vehicle deals damage when you accidentally run over a patient on the ground.
There was a problem hiding this comment.
I'd keep it, honestly.
Removed runover, might need to change the buckled_mob.dir to the ambulance bed moved thoug....ATV Turret still borked.
|
okay this is pretty much ready for review...i know the turret ATV is kinda iffy but... |
| keytype = /obj/item/key/ambulance | ||
| var/obj/structure/stool/bed/amb_trolley/bed = null | ||
|
|
||
|
|
There was a problem hiding this comment.
There's an extra empty line here
| bikecover = image("icons/vehicles/motorcycle.dmi", "motorcycle_overlay_4d") | ||
| bikecover.layer = MOB_LAYER + 0.1 | ||
|
|
||
|
|
|
I am now tigercat 2.0 |
|
Damn son. |
| /obj/vehicle/proc/remove_cell(var/mob/living/carbon/human/H) | ||
| if(!cell) | ||
| return | ||
| /obj/vehicle/Move(NewLoc,Dir=0,step_x=0,step_y=0) |
There was a problem hiding this comment.
Spacing here
/obj/vehicle/Move(NewLoc, Dir=0, step_x=0, step_y=0)
|
@monster860 Meaning that you leave inane line comments about "issues" with spacing that don't affect readability at all. |
| name = "Speedbike" | ||
| icon = 'icons/obj/bike.dmi' | ||
| icon_state = "speedbike_blue" | ||
| layer = OBJ_LAYER |
|
Some thing that need to be tested:
|
| step(src, direction) | ||
| update_mob() | ||
| handle_rotation() | ||
| if(istype(src.loc, /turf/simulated)) |
There was a problem hiding this comment.
This is probably the section you'll have to add if lube doesn't knock people off.
| if(is_cleanable(A)) | ||
| qdel(A) | ||
| if(istype(A, /obj/effect)) | ||
| if(is_cleanable(A)) |
There was a problem hiding this comment.
no need to check for if it's an effect and cleanable. Just the above for the F.dirt = 0 is necessary.
There was a problem hiding this comment.
well i need to keep the cleanabel part but i can remove the effect part yeah
ports tgstation/tgstation#14076
ports tgstation/tgstation#15725
to do:
Fix Turret ATV
Think of code for hookup of ambulance trolly bed to ambulance.....
馃啈 Fethas
rscdel: Nukes the cargo train code
rscadd:Adds simple vehicle framework and converts secway/janicart/snowmobiles/bikes/cars/ambulance to it
rscadd:Adds space speedbike, red and blue versions, yes you WILL need a spacesuit
rscadd:Maps janicart and secway onto metastation (but not ambulance no pareamedic garage, no i am not mapping that)
/:cl: