Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xenobio Addition #4189

Merged
merged 2 commits into from
Apr 27, 2016
Merged

Xenobio Addition #4189

merged 2 commits into from
Apr 27, 2016

Conversation

Fox-McCloud
Copy link
Member

@Fox-McCloud Fox-McCloud commented Apr 13, 2016

Ports half of my own PR from TG: tgstation/tgstation#16694

  • Adds in support for self-recharging cells; they regain 25% of their recharge rate every process (this is far far slower than putting them in a charger)
  • Slime cells self-recharge by default

馃啈 Fox McCloud
add: Slime batteries now self-recharge.
/:cl:

@Fox-McCloud Fox-McCloud added the Feature This PR is a new addition to the game label Apr 13, 2016
@Bigtimetripod
Copy link

Oh damn, here comes the wave of "NAW YUU CAN TURN SEC INTO WALKIN LING ARMY, NERF PLOX"

Or did that get removed... xenobio has gone thru so much changes lately in starting to loose track.

Oo.. self recharging cells... interesting. Xenobios effectivness just went up by.. 48%. Imagine, power outage, idiots eff up tesla (can happen) and APC are running dry... Xenobio to rescue! Im thinking the recharge rate is high enough to keep up RnD computer meaning it can print out more cells for departments that really need it and get singulo up and running.

Back to ling army topic... since its hard to get rainbows (late-round stuff) ye will not see much of sec/command transfering themself into lings. Maybe set somekind of SOP? Dunno, topic for higher minds.

@FlattestGuitar
Copy link
Contributor

There already is a science SOP, which every single science player ardently ignores. Currently everything about xenobio makes it turn into a horribly chaotic mess, but it stays in the room 90% of the time, so not that much of a problem.

This isn't really the topic of this PR though.

I'm pretty sure if the cells have a recharge rate this high they may be a bit too powerful. Does that mean you can make infinite stunprods? What about using them in APCs, will that disable the need for any external power most of the time?

@Fox-McCloud
Copy link
Member Author

The current self-recharge rate is very low; you're talking a mere +375 charge every 2 seconds (for slime cells)---it's not going to keep the power on, indefinitely, but it can be of use to keep things recharged, on the fly, that only see 1-2 uses and that's it---like defibs, for example.

@Regen1
Copy link
Contributor

Regen1 commented Apr 13, 2016

馃憥 馃挴 No please god no

Can we please NOT let people create their favorite mob just to take control over it themselves? This is literally as bad as just suiciding to join as an NPC, it's just a game mechanic that justifies it.

Play the role you've chosen

Who in their right mind would transfer their bloody soul into an unknown creature?

@tigercat2000
Copy link
Contributor

I'm going to with @Regen1 here.
Allowing players to deliberately make themselves into a simple animal of their choice is just god awful, and asking for trouble and metagaming.

@Spacemanspark
Copy link
Contributor

I think xenobiology has had enough changes and buffs.
馃憥

@marlyn-x86
Copy link
Member

+375 charge is sufficient to let a borg do whatever it wants and not fear ever running out, provided that it isn't spamming a borg RCD - as a cell in a mech, it'll let you take 37 steps every 2 seconds, of which you can only probably do 3-5.

Clearly, the answer is to have EMPing the cell produce... "Interesting" effects... 馃槇

@FalseIncarnate
Copy link
Contributor

I like the self-recharging cells support, pretty much makes a power equivalent to the experimental welding tool. Only real issue with it is that the uses are fairly limited since you can't swap batteries in the most common user of them: guns. Still, a self-charging APC or defib unit will be a handy tool for science to hook medbay up with. A self charging SMES might be interesting too, if those work with these.

I can't say I'm a huge fan of the new potion though. Perhaps allow you to transfer the consciousness between two different simple animals, like to transfer Ian's mind into a diyab or something, or between two human mobs (swap minds with your co-worker), but to allow the scientist to effectively throw himself into the newly spawned xeno queen or (as people have been worrying about) changeling would be a bit of borderline self-antag behavior.

I understand that it would largely be a one-way transference, since most mobs lack the capability to manipulate the items necessary to swap back, but that'd just encourage people to swap with the strongest and most versatile ones they can get (xenos, changelings, etc).

@Dumbdumn5
Copy link

Eh, I actually enjoy the new potion, mainly because we already have an extract that turns you into a slime. If there could be a blacklist on the more hostile mobs (xenos, changelings, etc.) I'd hope that'd at least change something. Everything else seems fine enough.

@TheDZD
Copy link
Contributor

TheDZD commented Apr 13, 2016

I like the idea of self-recharging batteries, but as long as players can make themselves into changelings, or other such mobs that are too absurdly powerful to have be allied with the crew, I'm going to have to vehemently disagree with the transference potion.

@Regen1
Copy link
Contributor

Regen1 commented Apr 13, 2016

@TheDZD this isn't just a "Balance" problem anymore, it's about players leaving their character to play a fucking simplemob

Let me put it differently, we would ban players from science if they went to xenobio, made sentient potions and a bunch of mobs, suicided and asked the other guy in xenobio to use the sentient potion on whatever animal.

This is just a game mechanic that somehow justifies something we would ban for.

@Iamgoofball
Copy link
Contributor

@Regen1 @tigercat2000 Realism is not going to overpower gameplay here. There's many many other actual balance issues you can argue with, like the headslug thing, or becoming hostile mobs in specific and using it to murderbone. Use those as argument points. No one in power is going to listen to you guys on the github if the only argument is "muh reels".

Your character is just a shell you inhabit. Why does it matter if you switch shells? Why does it matter if Randomname McRandomson the person who hasn't spoken to a single crewmember turns himself into a corgi? Why does it matter? Does them being a simple mob ruin YOUR fun in the game? Does a person playing a job that is already isolated from the station completely, turning themselves into a harmless animal, and fucking about not doing anything really cause a serious balance problem?

@Spacemanspark "lets just never change it ever again"
thats totally not the thinking that results in stagnant gameplay mechanics and departments that havent been updated in 5 years

@tigercat2000
Copy link
Contributor

@Iamgoofball I wasn't agreeing with his second point. Fuck balancing code around "realism", that's just stupid. I was agreeing with him because of letting people become any simple animal they so please is a very bad thing, especially with the tensions already around the fact that xenobiology can create little slave changelings to fight the antagonist.

@ProperPants
Copy link
Contributor

@tigercat2000 About the headslug thing, can't somebody just blacklist them? It's probably not as simple as just, but if it's such a catastrophic issue, shouldn't somebody be on it by now? Maybe someone is and I just don't know, but it seems theoretically simple (but of course that doesn't mean it's practically simple).

@Fox-McCloud
Copy link
Member Author

and metagaming.

Because someone in the round becoming a simple mob has more potential for metagaming than a ghost observer who has seen what's been going on for the past 15+ minutes.

@marlyn-x86
Copy link
Member

@Fox-McCloud In this case, the person becoming the simple mob has 100% control over what choices they want to become - a ghost observer lacks this agency, as they are not the one using the potion. Leading to, possibly, someone who really wants to be in a swarmer event, to create simplemobs till they get a swarmer, then becoming one and starting an antag event on their own initiative, all without interacting with anyone prior - we call this "Self antagging", no?

Is this simply to be a matter of administration?

@Fox-McCloud
Copy link
Member Author

@Crazylemon64

And then they get banned for griefing if they weren't an antag prior to turning themselves into one--the potion doesn't magically confer antag status on the person just because they have it; if they're a non-antag and they become something like that, then they're griefing.

That's no different than the person who goes scientist, and wants create an antag event of their own initiative, so they make a toxin's bomb and blow up the bridge/bar/what have you. We don't talk about removing Toxins because of that; we ban the person for griefing.

@Jedr-k
Copy link
Contributor

Jedr-k commented Apr 13, 2016

I'm not a fan of the current transference potion.

My biggest issue is the changeling headcrab.

Meta-/Powergamers WILL turn themselves into a changeling, and they can validhunt with their powers, cause unneeded chaos by kinda being an antag, but not really, and just in general cause more shit that we need to keep track of.

And if you're a traitor or any other kind of antag that benifits from having extra firepower, then it maybe makes sense, hell it could add some extra spice. Maybe not for all antags though. I really don't want any changelings in my cult.

At least blacklist the changeling headcrab for non antags, if that distinction is possible. Maybe some other mobs as wel, but I do feel that non-antags shouldn't be able to acces changeling powers like that.

I know that some people aren't a fan of players joining and "being useless". I guess this also falls under that category, but that's an aspect of the potion I don't have an issue with.

Griefers gonna grief, and they have much efficienter tools than this to do it.

Make an exception for the headcrab, and i'm game.
(You could always remove the headcrab as a gold slime spawnable mob, but this isn't the place for that discussion)

@Iamgoofball
Copy link
Contributor

@tigercat2000 Oh, sorry. Yeah, I can see the problem with "brb injecting self into space carp, its valid to kill then :^)". My main problem was muh reels as the excuse.

@fludd12
Copy link
Contributor

fludd12 commented Apr 15, 2016

Maybe the transference potion in another PR, due to the controversy? I feel like nobody'd object to a buff to the rarely used yellow battery reaction.

@Fox-McCloud
Copy link
Member Author

For reference, players can no longer receive headcrabs from gold slime cores: #4160

@tigercat2000
Copy link
Contributor

Still really don't like allowing people to put themselves in simple animal xenomorphs/drones/goliaths.

@Fox-McCloud
Copy link
Member Author

Fox-McCloud commented Apr 15, 2016

Still really don't like allowing people to put themselves in simple animal xenomorphs/drones/goliaths.

Which is inherently no different than pulling in a ghost for the same, exact thing. If anything, there's less metagaming potential with it since the user gains no ghost advantage.

@tigercat2000
Copy link
Contributor

@Fox-McCloud The difference is that you can have a reason beyond "a thing popped up and offered me a mob". Killing people, sneaking into places, or being a cute dog, or any other number of reasons, you get to decide to do so.

@Fox-McCloud
Copy link
Member Author

And so do they; they get a pop-up informing them if they want to be X mob, which they can decline or accept----and as they're a ghost, they can generally suss out who is or is not the antag, even without antag hud (not to mention it only takes one ghost to have antag hud on for alllll the ghosts to know). Do they get to choose, exactly? No, they don't, but they still have a decent amount of agency and judgment over things.

@fludd12
Copy link
Contributor

fludd12 commented Apr 15, 2016

I can see this becoming an interesting weapon of last resort for miners, where instead of dying, they become the goliath that would have killed them.

@Keilden
Copy link

Keilden commented Apr 15, 2016

I can see this becoming an interesting weapon of last resort for miners, where instead of dying, they become the goliath that would have killed them.

Captain Ginyu style?

@Rumiluntti
Copy link

Rumiluntti commented Apr 18, 2016

Stop shoveling buffs into science for fuck's sake
"add: Adds transference potion. A potion that allows the user to transfer their consciousness to a simple mob."

Oh god it's even worse than I feared! Why?! No. Holy shit, NO.

@Regen1
Copy link
Contributor

Regen1 commented Apr 21, 2016

I am still heavily against the transference potion

@Iamgoofball
Copy link
Contributor

Regen when are you going to provide a valid reason

@marlyn-x86
Copy link
Member

marlyn-x86 commented Apr 22, 2016

Being able to choose your shell allows you to vet your form for maximum power, and as stated above, changeling headcrabs will let any xenobiologist get all the powers of a changeling without any personal risk or loss- since they can just morph back to their original form once they become a humanoid changeling, and still have all the abilities of a normal human. This seems like it would inflame the already heavily present powergaming in science, wouldn't it?

@Regen1
Copy link
Contributor

Regen1 commented Apr 22, 2016

Who the fuck even is this guy?

Didn't github get an update? Can we please ban him already

@Fox-McCloud
Copy link
Member Author

@Crazylemon64

That hasn't been a thing for well over a week now

@Regen1

Knock it off with the personal attacks.

if(prompted || !ismob(M))
return
if(!isanimal(M) || M.ckey) //much like sentience, these will not work on something that is already player controlled
user << "<span class='warning'>[M] already has a higher consciousness!</span>"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to_chat

@Fox-McCloud Fox-McCloud changed the title Xenobio Additions Xenobio Addition Apr 27, 2016
@TheDZD TheDZD merged commit ddc459d into ParadiseSS13:master Apr 27, 2016
ParadiseSS13-Bot pushed a commit that referenced this pull request Apr 27, 2016
IK3I added a commit to IK3I/Paradise that referenced this pull request Apr 27, 2016
Delete spacepod.dm

Delete device.dmi

Adds Pod Keys and Gives Sec Pod a Lock

Update spacepod.dm

Update equipment.dm

Update spacepod.dm

Makes fridge boards be selectable

Screwdrive the board to select what type of fridge board you want.

:cl: pinatacolada
tweak: Makes fridge boards be selectable by screwdriving them
/:cl:

what falseincarnate said

SKREEEE

fixes ParadiseSS13#4259

Automatic changelog generation for PR ParadiseSS13#4258

Improves admin jump commands, forceMove

Fixes IPC deathgasp spam
Adds a brain damage threshold to the can_revive_by_healing proc to prevent braindead IPCs from continually dying and reviving.

Signed-off-by: HugoLuman <qaggeler@uci.edu>

Automatic changelog generation for PR ParadiseSS13#4282

Adds Disposals Chute to Mechanic's Workshop

Adds Disposals Chute to Mechanic's Workshop

Automatic changelog generation for PR ParadiseSS13#4285

PASS 1

TO DO: SCISSORS AND SHAVER REWORK

Pass2

Refactor scissors, fix and finalize prefs, fix missing part definition for xion models, etc.

continued: Monitor changing verb will now only show a list of monitor
styles available for the monitor head brand you are using.

For example, if you chose any of the regular monitor heads (default
morpheus or anything suffixed with mtr.) you will get a list of IPC
standard monitor styles and nothing else.
However, if you chose the hesphiastos alt head (which is also a monitor,
but of a different style) the list will be populated with the monitor
styles suitable for that hesphiastos head, but none others (not even the
ipc standard ones, since those don't fit and hesphiastos alt. isn't in
the models_allowed list)

Attaching a prosthetic head that isn't a monitor won't cause you to go bald & Fixes disembodied prosthetic heads being bald & ...

cont'd: Adds the rendering of markings on disembodied heads.

Fix - Main Entries in Primary Choice Only

Ensures the first choice posed to the user is one of companies that only
offer one model and single entries for companies that offer more than
one model

Fixes Runtime

Occurred when trying to list hair, marking or facial hair styles in
situations where the head is the default Morpheus head (no replacement
head).

Fixes Headlight Sprite and Fixes Hair+Head Accessory Animation

Hair and Head Accessories will now no longer animate as fast as they
possibly can and, instead, will follow the timings the spriter defined
in the .dmi file.

Fixes Xion alt. Head, Adjusts Morpheus and Xion alt. Head Optics

The Xion alt. head faced east even when you were facing west.

Adjusts the Zeng-hu Head Sprite

Automatic changelog generation for PR ParadiseSS13#4262

Ports Door Wands

fixes and defines

my code immersions

Automatic changelog generation for PR ParadiseSS13#4288

Abductor Camera Alt Fix

GODDAMN LIGGERS

adds key icon

Makes locks and keys buildable.

Xenobio Additions

no fun crew has arrived

Automatic changelog generation for PR ParadiseSS13#4189

Fixes an undefined var issue

Finalizes pod locks

Adds a lock to the the sec pod and a key for both the HoS and Pilot

Fixes a bug

Makes Pod Keys Preserved Items

Revert "Adds Pod Keys and Gives Sec Pod a Lock"

This reverts commit 6504d0e3899e461ef2cb79676a153149fec3d693.

Revert "Revert "Adds Pod Keys and Gives Sec Pod a Lock""

This reverts commit d8e5daafd4513b8a6c8a01218fbabd8e468b636d.
@Fox-McCloud Fox-McCloud deleted the xenobio-additions branch May 4, 2016 20:58
@ghost ghost mentioned this pull request Jan 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature This PR is a new addition to the game
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet