Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a new machine: The Pool Controller #527

Merged
merged 7 commits into from Mar 8, 2015

Conversation

tigercat2000
Copy link
Contributor

In essence, this makes a new machine using the sprite of an airlock controller, which controls the temperature of the nearest /turf/simulated/floor/beach/water. By default, this only lets people set the pool to cool down to 290k, or heat up to 330k. However, if emagged, there are two new modes: Hot and Freezing. The modes use the same code as the shower when wrenched, heating people to 500k or cooling people to 80k. This PR does not add it to the map, in order to avoid any merge conflicts.

@PJB3005
Copy link
Contributor

PJB3005 commented Mar 6, 2015

so... if the water can go down to 80K...

somebody code ice skates

also I feel like emagging's a little too much, the pool almost never gets used, so just some tools like screwdriver + multitool should have the effects of emagging IMO

/obj/machinery/poolcontroller/New() //This proc automatically happens on world start
for(var/turf/simulated/floor/beach/water/W in range(srange,src)) //Search for /turf/simulated/floor/beach/water in the range of var/srange
src.linkedturfs += W //Add found pool turfs to the central list.
processing_objects.Add(src) //Add the pool controller to the processing queue to tie mob effects to the air controller.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use ..() instead of processing_objects.Add(). It should get added automatically.

@ZomgPonies ZomgPonies added Feature This PR is a new addition to the game Map Edit This PR will modify a map labels Mar 6, 2015
@tigercat2000
Copy link
Contributor Author

Ehm, Ponies, I actually didn't add it to the map, as i did not want to cause any merge conflicts.

@ZomgPonies ZomgPonies removed the Map Edit This PR will modify a map label Mar 6, 2015
temperature = "hot"
usr << "<span class='warning'>You flick the pool temperature to [temperature](WARNING).</span>" //Differ from standard message to make sure the user understands the temperature is harmful.
return
if("Cold")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

recommend a different descriptors for these; "scalding" and "frigid" to get across how insanely hot/cold they are.

@fj45
Copy link
Contributor

fj45 commented Mar 6, 2015

Ahahah thats a fun little feature. Shower temp code is very, very old. (From what I have heard and experienced atleast.) So you will get some issues like hardsuits not protecting you from the heat/cold.

@Fox-McCloud
Copy link
Member

@fj45

Yeah, ideally it would be the turf itself that's cold/drops in temperature, rather than setting the mobs body temp directly.

@tigercat2000
Copy link
Contributor Author

Not possible with ZAS, AFAIK.

@Fox-McCloud
Copy link
Member

@tigercat2000

Oh, it's possible, you'd just probably have to snowflake it---not good.

ZomgPonies added a commit that referenced this pull request Mar 8, 2015
Adds a new machine: The Pool Controller
@ZomgPonies ZomgPonies merged commit 1b1c460 into ParadiseSS13:master Mar 8, 2015
@tigercat2000 tigercat2000 deleted the Poolmagic branch March 8, 2015 17:26
mattgroy pushed a commit to mattgroy/Paradise that referenced this pull request Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature This PR is a new addition to the game
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants