Adds config option to let players see their own notes.

[monster860]

It's a fucking config option, and it's not enabled by default

The salt is real

I'm 99% sure it says somewhere on my notes that I wrote a translator script in NTSL. By the way, I NEVER FUCKING WROTE THAT SCRIPT

There's literally no way to know if there's inaccurate data in your notes.

Okay, fine, I'll stop spamming the H1 text.....

Ported from tgstation/tgstation#6490

When enabled in config.txt, this allows players to see their own notes.

Eh, at this point we've been making notes without the intent of showing it to any non-admin for years.
Can't exactly transfer to a different, more public method just at the snap of a finger.

-FreeStylaLT

And.. now you can.

🆑 monster860
rscadd: Adds a config option to allow players to see their own notes.
/:cl:

[Wheatley29]

The point of notes is so admins know who does what and who to look out for, not so players know when the admins are onto them doing X, so they instantly stop.

[TullyBurnalot]

No.

No.

No.

Those are kept Admin-Only for a reason.

[Rumiluntti]

Lol no

[Fox-McCloud]

The point of notes is so admins know who does what and who to look out for, not so players know when the admins are onto them doing X, so they instantly stop.

[Alexshreds]

Admins everywhere are cringing.

[fludd12]

It's not enabled by default, guys. It's an option.

[monster860]

It's not enabled by default! It's an option

[fludd12]

I'd say, at the least, more tools for our config menu can't hurt. If, in the future, policy changes on notes, this would be good to have.

[sasanek12]

Nope. Nein. Niet.

[Wheatley29]

Okay, that still changes nothing as it will still allow every player to see what the administration team thinks of their actions, by that note it would basically mean that EVERYONE with a single word on their notes would have it blocked, making it redundant

[Rumiluntti]

Useless option, that's as useful as adding "YOU CAN ALSO SHIT YOUR PANTS!!" -posters in your toilet.

[Wheatley29]

Controversial tag?

[FlattestGuitar]

I think this PR will have a very unanimous reception.

[TullyBurnalot]

@Wheatley29 This is not "controversial" so much as it is "universally reviled".

[FreeStylaLT]

I do not really see any reason to have this as an option, even. Since, this will never happen, if only because we have simply been noting people without ever intending to show them to any player. We cannot reasonably edit those notes before showing them to everyone, nor can we change our note methodology to fit the new public view it would have, this is simply infeasible.

[Alexshreds]

I dare someone to give it a thumbs up.
💀

👍 to Mijhead

[FreeStylaLT]

AND TRAVIS FAILS.

[Wheatley29]

This PR was a shitstorm from the start

[Alexshreds]

code/game/verbs/ooc.dm:238:error: see_own_notes: undefined proc
code/modules/admin/sql_notes.dm:181:error: show_note: duplicate definition
code/modules/admin/sql_notes.dm:114:error: show_note: previous definition
code/modules/admin/sql_notes.dm:199:warning: id: variable defined but not used
code/modules/admin/sql_notes.dm:203:warning: last_editor: variable defined but not used

[Little-119]

Even if Paradise admins don't plan on showing players their notes, a downstream server's admins might want to. Downstream servers are the reason revolution was updated despite it not being in rotation, if I recall correctly.

[Wheatley29]

And even if it is an option, it will be used maximum once and then never again, thus wasting space and collecting dust

[Fox-McCloud]

upvoting your own PR.

Shameful.

[monster860]

upvoting your own PR.

Shameful

But... But... REDDIT.

[Wheatley29]

@monster860, what in your opinion, is the point of adding this to the server?

[monster860]

There's no way for players to know if there's incorrect data in their notes right now. Like I said, I wouldn't be surprised if it said in my notes that I wrote the translator script, but I never wrote that script.

Besides, I saw this in the tg codebase and just had to port it over.

[monster860]

The fact that so many admins are against this makes me really worried about the contents of my notes.

[FreeStylaLT]

The fact that so many admins are against this makes me really worried about the contents of my notes.

Perhaps that is for the better.

[Jedr-k]

@monster860 This is not about you. This is apparently about your lack off insight into how we like to run this server.

Notes are a thing we as admins use to keep track of what transpires during rounds. They're not meant to be public. While perhaps a public system parallel to the notes might be implemented one day, that isn't what this PR does. This option won't ever be enabled. I don't see why the maintainers would have to put effort into reviewing this.

Sorry to say, your effort here was for nothing.

[monster860]

@Draconic-saint I noticed.