Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows slime people to change color in lobby. #548

Merged
merged 9 commits into from Mar 11, 2015

Conversation

tigercat2000
Copy link
Contributor

This PR allows for slime people to select their color in the setup character menu.
The SQL schema has been updated to save this preference, which should be taken into account on downstream server databases.

@mvanalphen mvanalphen added the Feature This PR is a new addition to the game label Mar 9, 2015
@mvanalphen
Copy link
Contributor

As all donators with the slime color changer fluff item have been contacted (and only one responded after more than a week), we're good to have this one in once the 24h period passes.

This includes a MySQL change. Do not merge/patch this until this change has been applied to the database.

@ZomgPonies ZomgPonies added the Do Not Merge This PR must not be merged or closed label Mar 9, 2015
@ZomgPonies
Copy link
Contributor

Also make sure the slime colors update properly in proc/update_preview_icon

@tigercat2000
Copy link
Contributor Author

Slime people previews do not work at all.- Note, working on this issue now, also working on getting ID cards to properly display color, as slimes can spawn with a chosen color, it should be on their ID's

@tigercat2000
Copy link
Contributor Author

@ZomgPonies proc/update_preview_icon and datacore rendering of slime people color on PR #548 is working

@Spacemanspark
Copy link
Contributor

Tajaran always appear black on their ID card, mind looking into that as well?

@tigercat2000
Copy link
Contributor Author

That is beyond the scope of this PR, but, I'll look into it once this is merged/closed

@Spacemanspark
Copy link
Contributor

Alrighty.

@ZomgPonies ZomgPonies removed the Do Not Merge This PR must not be merged or closed label Mar 11, 2015
ZomgPonies added a commit that referenced this pull request Mar 11, 2015
Allows slime people to change color in lobby.
@ZomgPonies ZomgPonies merged commit c693be1 into ParadiseSS13:master Mar 11, 2015
@tigercat2000 tigercat2000 deleted the SlimeColorChanger branch March 20, 2015 10:20
Zigamus pushed a commit to Zigamus/Paradise that referenced this pull request Jan 16, 2022
mattgroy pushed a commit to mattgroy/Paradise that referenced this pull request Nov 10, 2023
<!-- Пишите **НИЖЕ** заголовков и **ВЫШЕ** комментариев, иначе что то
может пойти не так. -->
<!-- Вы можете прочитать Contributing.MD, если хотите узнать больше. -->

## Что этот PR делает
Исправляет баг

![image](https://github.com/ss220club/Paradise-SS220/assets/20109643/319a0f57-7c63-48ba-ae10-28df087a4911)

## Почему это хорошо для игры
Баги плохо

## Изображения изменений
<!-- Если вы не меняли карту или спрайты, можете опустить эту секцию.
Если хотите, можете вставить видео. -->

## Тестирование
Потыкал картой в игре - работает

## Changelog

:cl:
fix: Пофиксил взаимодействие с мехами
/:cl:

<!-- Оба :cl:'а должны быть на месте, что-бы чейнджлог работал! Вы
можете написать свой ник справа от первого :cl:, если хотите. Иначе
будет использован ваш ник на ГитХабе. -->
<!-- Вы можете использовать несколько записей с одинаковым префиксом
(Они используются только для иконки в игре) и удалить ненужные. Помните,
что чейнджлог должен быть понятен обычным игроком. -->
<!-- Если чейнджлог не влияет на игроков(например, это рефактор), вы
можете исключить всю секцию. -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature This PR is a new addition to the game
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants