Turns Vox Raiders into Space Pirates/Traders/Raiders/Call it what you will #5625

FlattestGuitar · 2016-09-05T11:31:24Z

🆑 FlattestGuitar
rscdel: absolutely kills Vox Raiders as a gamemode
rscadd: adds Raiders as a gamemode with more rum and less skrek
rscadd: adds the AP10, a 10mm machine pistol, only available to Raiders
rscadd: adds a swanky space pirate Plasmaman suit, again, only Raiders
/:cl:

Ooookay, so:
Considering Vox Raiders is widely considered to be an incredibly flawed gamemode and has been taken out of the standart rotation without much protest, I've decided to simply work on top of it, pretty much nuking the thing in favour of THIS. If that's an issue, I'll gladly redo all of the work I've done in another spot, so the old gamemode is still accessible, as it's kinda my fault for not asking in the first place.

This PR also adds a new weapon!
A 10mm machine pistol - the AP10
two round burst, 24+1 ammo, 30 damage per shot, quite powerful

Also adds this neat plasmaman suit

Here's a list of features that are already in or are intended to be in eventually, in no particular order:

All raiders KEEP their selected species, getting a random name and appearance. This spices things up and makes for more interesting RP.
All raiders get a normal survival box with two additional 20u synthflesh patches inside.
All raiders get a random space suit and a random firearm with a reasonable supply of ammo. If their firearm is crap, they also get a melee weapon to improve their chances.
The raiders get a large amount of random stuff that can be valuable to the crew. Materials, tech disks, pizza, fancy hats, things that will make it possible to actually trade with them.
Raiders get objectives that can either be objectively antagonistic (kidnap, assasinate) or can be reached through trade and cooperation with the crew. Attacking them preemptively because of the metagamey "They have to hurt us eventually" won't work. That said, if the raiders need to get an emitter, they might as well slice and shoot their way to it, if they please.
The raider crews can be anywhere from 3 to 6 people (will prolly tweak that), so as not to have negotiations along the lines of "There's always five of you, why did only four come?"
I MAY end up adding the Trader-style hail and docking request in the future, but that depends on whether people like the idea or not, on top of the fact that there's not much room left after the traders were given the current system

TO DO:

BECAUSE I CHANGED ROLE DEFINES, THIS WILL NEED THE DB MODIFIED. I don't know how to do that, so someone else will have to figure out the query.

Rapidvalj · 2016-09-05T11:32:40Z

but, muh voxxy raiders, SKREEEEEEEEEEE

Kyep · 2016-09-05T11:34:39Z

I like the concept. Vox Raiders are stale for lots of reasons. This could be more interesting.

FlattestGuitar · 2016-09-05T11:53:26Z

code/game/gamemodes/heist/heist.dm

 	var/win_button_triggered = 0

 /datum/game_mode/heist/announce()
 	to_chat(world, "<B>The current game mode is - Heist!</B>")
 	to_chat(world, "<B>An unidentified bluespace signature has slipped past the Icarus and is approaching [station_name()]!</B>")
 	to_chat(world, "Whoever they are, they're likely up to no good. Protect the crew and station resources against this dastardly threat!")
-	to_chat(world, "<B>Raiders:</B> Loot [station_name()] for anything and everything you need, or choose the peaceful route and attempt to trade with them.")
-	to_chat(world, "<B>Personnel:</B> Trade with the raiders, or repel them and their low, low prices and/or crossbows.")
+<<<<<<< HEAD


Thanks, Github. <3

actually this is git's fault, not github's.

IcyV · 2016-09-05T11:58:50Z

I'm liking the idea for sure. The only part I have issue with is

Raiders get no EMP weapons, because that's silly if they have IPCs on the team.

That seems odd to me. If there are IPCs they should just have to be careful and keep it in mind. There's potentially other very valid reasons for not having EMP weapons, but I don't agree with that one. Nuke ops could be very explosive when exposed to EMPs but they still got one.

tristan1333 · 2016-09-05T12:15:36Z

I love the idea of spess pirates flat man. I honestly prefer stereotype pirates, but that's just me personally lmao. But this is really cool and is a better take than Vox Raiders. (Even though I love Vox, muh Skree)

Regen1 · 2016-09-05T12:33:23Z

EMP should be a part of their arsenal

Just watch your fire, we shouldn't be hugboxing because of a balance choice of a specific race

FlattestGuitar · 2016-09-05T12:52:08Z

Good points, actually.

Sacrificing fidelity for safety is a bad idea.

tigercat2000 · 2016-09-05T14:14:06Z

code/game/area/Space Station 13 areas.dm

 	icon_state = "yellow"
 	requires_power = 0
 	lighting_use_dynamic = 0
 	no_teleportlocs = 1

-/area/vox_station/transit
+/area/raider_station/transit


you can kill this, transit areas are no longer a thing

GeneralChaos81 · 2016-09-06T00:53:10Z

Re-the uranium bit. One time as a vox raider my team and I broke into mining base and collected our own ores. We needed help refining them into plasteel though.

KasparoVy · 2016-09-06T01:22:40Z

Going to seriously miss Vox raiders (as I have been already 😞), but hopefully this is easier to balance and manage.

KasparoVy · 2016-09-06T01:29:08Z

code/game/gamemodes/objective.dm

+		if(7)
+			target = /obj/item/weapon/gun/energy/gun/hos
+			target_amount = 1
+			loot = "the renovated Head of Security's energy gun"


"the Head of Security's recreated antique laser gun"

Rumiluntti · 2016-09-06T09:29:41Z

Give them permaslur and sober gene. Otherwise looks good!

HugoLuman · 2016-09-06T23:33:08Z

This solves a problem with Vox raiders, mainly that it was difficult NOT to metagame, since the crew knew that the Vox were likely to cause trouble, and that killing them would end the round. I don't think we should utterly nuke Vox raiders, but rather, like xenos, remake them into a random event.

Also, you know what would be a neat variant on this gamemode (as in, have in addition to this)? [SPECIES] Raiders as opposed to Vox Raiders. Sometimes a random crew of one race comes to plunder/trade. Perhaps some species get weird things on their ships (Like maybe IPC ships get stuffed with inert CO2, cuz they only need it to pressurize their ships).

taukausanake · 2016-09-07T02:06:33Z

I agree with Hugo, don't nuke Vox Raiders but keep it as a random event. I also like the idea of different species raiders. Interesting things can come from having slime or Plasmamen crews arriving. The only thing there is deciding what each specie could bring special to them

Fox-McCloud · 2016-09-07T05:02:39Z

There's no point in keeping Vox raiders around with this refactor. @TheDZD has already expressed support in killing off Vox Riaders, specifically, and I'm inclined to agree with him.

Taaketa · 2016-09-07T13:39:53Z

Kill it. This game mode looks better.

HugoLuman · 2016-09-08T01:16:29Z

I'd be willing to do the legwork for a "same-species crew of a random race" variant, which might include Vox raiders. As an event, that is. It might sound redundant at first, but I think it'd actually help keep things varied and unpredictable. Particular if certain race-crews got their own weird features on the ship.

FlattestGuitar · 2016-09-08T09:00:54Z

Okay, well, at this point I feel like most of the integral systems are ready.

The things I'm mostly worried about currently is adding more interesting objectives that are doable within the scope of this PR and don't require the revamping of the whole game.

As the merge conflicts are mostly caused by the map changes, and there are two other mapping PRs that are most likely going to get merged before this one, I'll leave them alone for now, until those two get closed.

I'm still very much looking for more ideas that won't be a major pain to implement, but I think I'll be starting to run some public tests soon-ish.

HugoLuman · 2016-09-08T21:45:25Z

Well, what else would raiders do aside from "Acquire things and/or people, leave" ?

GeneralChaos81 · 2016-09-08T23:15:03Z

If they're properly armed now, they could have to kill someone(s)?

HugoLuman · 2016-09-09T02:24:52Z

I don't think that would work very well. Either they ambush them and gun them down, and the round immediately ends, or they have to get the body back to their base to prevent cloning. Which is pretty much the same as kidnapping them anyway

FlattestGuitar · 2016-09-09T08:22:25Z

Currently the raiders have four objectives, most of them are still there after Vox Raiders.

Steal an item, items ranging from emitters to the CMO's hypospray can be on that list, so they may have to drag the item through the whole station to get it safely back to their ship
Kidnap a person, they have to take one person with them back onto the ship. While it's technically possible for the person to agree to that, I doubt that will ever happen.
Murder a person, literally the same thing as the traitor objective. Don't let them get revived by the end of the shift.
Salvage materials, obtain X amount of sheets of a mineral. I think this one is dull and makes little sense, If there are no miners, there will be no minerals, and we shouldn't make the raiders literally mine for that stuff. That's silly.

Plotron · 2016-09-11T12:40:30Z

Is steal an AI also an objective? I feel like that's... a rather fitting one for spess pirates.
Granted, it could be too easy given their numbers, but it should be just one of many, MAANY objectives.

Also we could have a maim objective, y'know - bones. Harassment, just a side-job. Could be some kind of personal revenge.

Fox-McCloud · 2016-09-12T19:19:57Z

data/mode.txt

@@ -1 +1 @@
-extended
+heist


FlattestGuitar · 2016-09-13T22:14:55Z

Notes:

this is a map edit PR, needs the flag
merge conflicts are kil (FINALLY, GOD)
this PR is pretty much ready for review
I know I did some really weird shit with Metastation, as well as z2. I'm not exactly sure how the system works and why we have so many z2s in our files, but someone should probably double-check if everything is in order.

Fox-McCloud · 2016-09-25T06:54:53Z

code/game/gamemodes/heist/heist.dm

-		raider_num = recommended_enemies
+
+
+	raider_num = rand(required_enemies, min(recommended_enemies, candidates.len))//pick a random amount, from the minimum up to the maximum, if numbers permit


Generally not a good way to balance a game mode; this should either be static and they're given extra gear to compensate for there being more players, orrrr their own number scale with the amount of players.

Fox-McCloud · 2016-09-25T06:55:45Z

code/game/gamemodes/heist/heist.dm

+
+	M.underwear = "Nude"
+	M.undershirt = "Nude"
+	M.socks = "Nude"


Spess pirates so tough they ain't got time to wear underwear.

Fox-McCloud · 2016-09-25T06:57:58Z

code/game/objects/effects/spawners/lootdrop.dm

@@ -195,5 +195,6 @@
 				/obj/item/weapon/spacecash/c200 = 1,
 				/obj/item/weapon/airlock_electronics = 1,
 				/obj/item/weapon/gun/energy/kinetic_accelerator/super = 1,
-				/obj/item/pizzabox = 3,
+				/obj/item/pizzabox/margherita = 1,
+				/obj/item/pizzabox/meat = 1,


Really don't think these should be added to the maintenance loot table in this PR.

Fox-McCloud · 2016-09-25T06:58:47Z

code/modules/mob/living/carbon/human/species/plasmaman.dm

+			helm = /obj/item/clothing/head/helmet/space/eva/plasmaman/mime
+	if(H.mind.special_role == SPECIAL_ROLE_RAIDER)
+		suit = /obj/item/clothing/suit/space/eva/plasmaman/raider
+		helm = /obj/item/clothing/head/helmet/space/eva/plasmaman/raider


This whole thing is disgusting.

Fox-McCloud · 2016-10-05T15:32:46Z

Conflicts.

mvanalphen · 2016-10-24T11:07:17Z

@FlattestGuitar Conflicts!

FlattestGuitar · 2016-10-24T11:33:15Z

I know. I've fixed the conflicts way too many times now. I'll wait until this is the oldest mapchange PR or Fox pokes me.

taukausanake · 2016-10-25T05:37:00Z

Might as well wait until the feature freeze is done, that seems to be what's keeping anything other than fixes from being pushed

Spacemanspark · 2016-10-29T18:00:42Z

Please yes.
Please merge this before I get back.

FlattestGuitar reviewed Sep 5, 2016
View reviewed changes

tigercat2000 reviewed Sep 5, 2016
View reviewed changes

Fox-McCloud added Feature This PR is a new addition to the game Refactor This PR will clean up the code but have the same ingame outcome labels Sep 5, 2016

KasparoVy reviewed Sep 6, 2016
View reviewed changes

Fox-McCloud added the Merge Conflict This PR is merge conflicted label Sep 7, 2016

Fox-McCloud reviewed Sep 12, 2016
View reviewed changes

Fox-McCloud added Map Edit This PR will modify a map and removed Merge Conflict This PR is merge conflicted labels Sep 15, 2016

Fox-McCloud reviewed Sep 25, 2016

View reviewed changes

Fox-McCloud added the Merge Conflict This PR is merge conflicted label Oct 5, 2016

marlyn-x86 removed the Merge Conflict This PR is merge conflicted label Nov 28, 2016

FlattestGuitar closed this Nov 28, 2016

FlattestGuitar mentioned this pull request Nov 28, 2016

Space Pirates #5925

Closed

11 tasks

		raider_num = recommended_enemies


		raider_num = rand(required_enemies, min(recommended_enemies, candidates.len))//pick a random amount, from the minimum up to the maximum, if numbers permit

		@@ -1 +1 @@
		extended
		heist

Turns Vox Raiders into Space Pirates/Traders/Raiders/Call it what you will #5625

Turns Vox Raiders into Space Pirates/Traders/Raiders/Call it what you will #5625

Conversation

FlattestGuitar commented Sep 5, 2016 • edited

Rapidvalj commented Sep 5, 2016

Kyep commented Sep 5, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

IcyV commented Sep 5, 2016

tristan1333 commented Sep 5, 2016

Regen1 commented Sep 5, 2016

FlattestGuitar commented Sep 5, 2016

Choose a reason for hiding this comment

GeneralChaos81 commented Sep 6, 2016

KasparoVy commented Sep 6, 2016 • edited

Choose a reason for hiding this comment

Rumiluntti commented Sep 6, 2016

HugoLuman commented Sep 6, 2016

taukausanake commented Sep 7, 2016

Fox-McCloud commented Sep 7, 2016 • edited

Taaketa commented Sep 7, 2016

HugoLuman commented Sep 8, 2016

FlattestGuitar commented Sep 8, 2016

HugoLuman commented Sep 8, 2016

GeneralChaos81 commented Sep 8, 2016

HugoLuman commented Sep 9, 2016 • edited

FlattestGuitar commented Sep 9, 2016

Plotron commented Sep 11, 2016 • edited

Fox-McCloud Sep 12, 2016 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

FlattestGuitar commented Sep 13, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Fox-McCloud commented Oct 5, 2016

mvanalphen commented Oct 24, 2016

FlattestGuitar commented Oct 24, 2016

taukausanake commented Oct 25, 2016

Spacemanspark commented Oct 29, 2016

FlattestGuitar commented Sep 5, 2016 •

edited

KasparoVy commented Sep 6, 2016 •

edited

Fox-McCloud commented Sep 7, 2016 •

edited

HugoLuman commented Sep 9, 2016 •

edited

Plotron commented Sep 11, 2016 •

edited

Fox-McCloud Sep 12, 2016 •

edited