Enables Syndicate Paparazzi #6966
Conversation
|
Thage her beat 馃憣 |
|
Thats very neat, damn autocorrect |
code/game/gamemodes/objective.dm
Outdated
| if (steal_target.check_special_completion(I)) | ||
| return 1 | ||
|
|
||
| return 0 |
There was a problem hiding this comment.
This will break things; for instance, slime cores that are used and AI cards without anything in them will trigger this as a "success".
There was a problem hiding this comment.
This works @Fox-McCloud
|
Make it require to be a 1x1 photo |
|
I mean its not like syndiecate want a photo where you can barely see the blueprints |
code/game/gamemodes/objective.dm
Outdated
| var/list/all_items = owner.current.GetAllContents() | ||
|
|
||
| for(var/obj/I in all_items) | ||
| if(istype(I, steal_target)) |
There was a problem hiding this comment.
this is a /datum/theft_objective, so this needs to be if(istype(I, steal_target.typepath)), now this is different to how /tg/ does it, and I've only just glanced at your code, but @Fox-McCloud confirm?
There was a problem hiding this comment.
@RemieRichards Thats the conclusion we reached as well!
There was a problem hiding this comment.
Ah splendid, good to know my brain still works before lunch.
There was a problem hiding this comment.
@RemieRichards embarressingly it works for the things I was testing... AIs, slime cores, blueprints.... but breaks and auto-greentexts everything else. Red cheeks.
code/game/gamemodes/objective.dm
Outdated
|
|
||
| for(var/obj/I in all_items) | ||
| if(istype(I, steal_target)) | ||
| return 1 |
There was a problem hiding this comment.
this should be return steal_target.check_special_completion(I)
(then removing the second if below)
|
Hai, @RemieRichards. Funny you should post when you did; about 10 minutes before you posted, I told him pretty much what you did, then stated something along the lines of "give yourself the steal the HoS's energy gun objective; I bet it greentexts if you have a single object on you" |
|
Heh. |
SamHPurp
changed the title
|
@Fox-McCloud So I fixed this, with the correct way of running this loop, and had to add a new check on top for the alternative items. Objectives now have an alternate item list, so if this does need to expand to other things in the future, this is easy to do.
|
SamHPurp
changed the title
| var/flags=0 | ||
| var/list/protected_jobs = list() | ||
| var/list/altitems = list() | ||
| var/flags = 0 | ||
|
|
||
| /datum/theft_objective/proc/check_completion(var/datum/mind/owner) |
There was a problem hiding this comment.
I don't think this is even used anymore. Should look into this more, but if it's not, then the safety checks from this should probably be moved to /datum/objective/steal/check_completion and this proc removed.
There was a problem hiding this comment.
This comment still remains @SamHPurp
There was a problem hiding this comment.
@Fox-McCloud will review in the morning.
There was a problem hiding this comment.
@Fox-McCloud this is still used, for checking credits for a 'money theft' objective... which I've never seen actually utilised.
Want me to leave it? Or rip out the whole money-theft thing.
There was a problem hiding this comment.
Actually this is also used to determine the fullness of a Plasma tank for the Plasma objective.
Might be worth leaving it, unless you have a better suggestion?
There was a problem hiding this comment.
Wait, you can steal money? Why is that not an objective? That would be great to steal credits from other peoples accounts
There was a problem hiding this comment.
REEEeeeeeEEEeeEEEEe.
Objective code. This can just be refactored later, I guess.
|
I could've sworn this was already a thing a few years back. |
|
@Xantholne not on Paradise, but on TG, and maybe even Bay. |
馃啈 Purpose2
add: Can now take photos of the Blueprints to count as a completed objective.
/ :cl: