Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enables printing of Demotion console circuitboards #7645

Closed

Conversation

SamHPurp
Copy link
Contributor

@SamHPurp SamHPurp commented Jun 27, 2017

Continuing the trend of making everything (within reason) constructible, and that this was missed off of #6766, admitted by the author here - I figured I'd rectify it.

馃啈 Purpose2
add: Demotion console circuitboard designs now available from your local Research and Development laboratory!
/ :cl:

@Kyep
Copy link
Contributor

Kyep commented Jun 27, 2017

May want to check that the computers built with these cards work as well as the normal computers.

@SamHPurp
Copy link
Contributor Author

@Kyep I demoted an engineer with a CE card from a CE console, and demoted a doctor with a CMO card from a printed CMO circuit.

@tigercat2000 tigercat2000 added the Feature This PR is a new addition to the game label Jun 27, 2017
@ghost
Copy link

ghost commented Jun 27, 2017

Wouldn't it be better to allow screwdrivering an ID Console board instead of adding 4 new designs?

@Fox-McCloud
Copy link
Member

What @uraniummeltdown said.

Also, this should have been made so that the ID console allows selective hiring/firing based on the ID inserted into it, and not distinctive var requirements on each console (yuck).

@SamHPurp
Copy link
Contributor Author

Refactoring a recently merged feature - with how long it took for it to be reviewed seems crazy. This should have been caught in the initial review no?

I'm going to close this and fix in sometime in the future.

@SamHPurp SamHPurp closed this Jun 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature This PR is a new addition to the game
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants