Adds in Kidan variants [WIP] #7665

shazbot194 · 2017-06-29T09:30:52Z

After a lot of talks with several people, instead of adding in a new race, this PR will be adding in a sub-species to the Kidans. Each variant of the Kidans shares the same base stats, but each has a unique function. The current Kidans have Bio-luminescence, and for the first variant, the Moths, they would be able to fly in 0G, as long as there is air, and they are not wearing a suit. The different sub species would also look different, but be noticeable insect like, as well as based off the current Kidan sprite.

Here is the first one, a moth like variant. They won't look like this in the final version, but here is an about what they will look like.

(do not take the use of HUDs here as them being able to use them as these were taken pre-Kidan merging, back when they could wear glasses)

Travelling Merchant is helping with the spriting, and here is what he is proposing, keep in mind that it is not colored at all, so it will not look so mono-tone when its ready.

As of right now, the code to make it possible to have a sub species is implemented, which is really using the icon based skin tone system and having it rename itself in the menu when its used for sub species, as is having mechanical differences between sub species.

Here is how it looks when you have a Kidan, notice the new Sub Species option.

And when you change it to the new Moth sub species, this is what you see, I only colored the different parts to make it easier to see which is which. These sprites are also not the final ones that will be included.

In addition, as possible lore reasons why Kidan would have sub species that are so vastly different, there is already quite a good explanation in the current Kidan lore. In the year 2170, the Kidan discovered plasma on their home planet, and due to a major lack of safety measures, a lot of the population was exposed and mutated. A lot of females became savage and some of those who didn't became god like. We aren't told much else about other mutations that happened, and it wouldn't be too far fetched to imagine the plasma bringing back old inactive genes or adding in new ones that made them physically different.

This PR uses ported code from from Hippie, namely the sprites. I will also at some point possibly be porting over the sounds too, so all credit for the original art and sounds to whoever made them.

Ports Moths from Hippie. Will add more to the description to in a littlebit.

yes

Ready to be shown

SamHPurp · 2017-06-29T09:40:49Z

Lasshy's wings fluff got rejected and has gone an alternate route to get wings...

Please, just no. I don't think we need even more races... Hippie memes?

shazbot194 · 2017-06-29T09:43:34Z

While I can understand where you are coming from, the PR is here and should be judged on its own, that is, when it is up for judgement. It already has received some support from other people other then Lasshy as well.

Birdtalon · 2017-06-29T09:40:18Z

code/modules/mob/language.dm

@@ -268,6 +268,17 @@
 	flags = RESTRICTED | WHITELISTED
 	syllables = list("click","clack")

+/datum/language/moth
+	name = "Gypsikin"
+	desc = "The noise made by rubbing its furry antennae together is actually a complex form of communication for Kidan."


"for Lymantria"

Good point, I will fix it when I am awake.

Birdtalon · 2017-06-29T09:43:04Z

code/modules/mob/living/carbon/human/species/station.dm

+		light_amount = min(T.get_lumcount() * 10, 5)  //hardcapped so it's not abused by having a ton of flashlights
+
+
+	if((light_amount >= 5) && !H.suiciding) //if there's enough light, heal


Do they heal in light or just move at a standard speed, if so what is the rate of healing?

They just move normal speed, I forgot to take out the second part.

Birdtalon · 2017-06-29T09:44:27Z

code/game/gamemodes/wizard/artefact.dm

@@ -326,7 +326,7 @@ var/global/list/multiverse = list()
 		M.set_species(user.get_species()) //duplicate the sword user's species.
 	else
 		if(prob(50))
-			var/list/all_species = list("Human","Unathi","Skrell","Tajaran","Kidan","Golem","Diona","Machine","Slime People","Grey","Vulpkanin")
+			var/list/all_species = list("Human","Unathi","Skrell","Tajaran","Kidan","Golem","Diona","Machine","Slime People","Grey","Vulpkanin", "Lymantria")


Should there be a space?

Nope, thanks for noticing.

SamHPurp

I don't think these have a place here.

SamHPurp · 2017-06-29T09:41:33Z

code/game/gamemodes/wizard/artefact.dm

@@ -326,7 +326,7 @@ var/global/list/multiverse = list()
 		M.set_species(user.get_species()) //duplicate the sword user's species.
 	else
 		if(prob(50))
-			var/list/all_species = list("Human","Unathi","Skrell","Tajaran","Kidan","Golem","Diona","Machine","Slime People","Grey","Vulpkanin")
+			var/list/all_species = list("Human","Unathi","Skrell","Tajaran","Kidan","Golem","Diona","Machine","Slime People","Grey","Vulpkanin", "Lymantria")


inconsistent spacing

SamHPurp · 2017-06-29T09:42:28Z

code/modules/mob/language.dm

@@ -268,6 +268,17 @@
 	flags = RESTRICTED | WHITELISTED
 	syllables = list("click","clack")

+/datum/language/moth
+	name = "Gypsikin"
+	desc = "The noise made by rubbing its furry antennae together is actually a complex form of communication for Kidan."


For Kidan? Also this sentence isn't structured well.

That is because its way to late for me to be writing code, and I didn't fix all the old text from what this originally was. I'll fix it when I am not about to pass out.

Probably best not to copy paste stuff in the first place.

SamHPurp · 2017-06-29T09:42:52Z

code/modules/mob/language.dm

+	name = "Gypsikin"
+	desc = "The noise made by rubbing its furry antennae together is actually a complex form of communication for Kidan."
+	speech_verb = "rubs its antennae together"
+	ask_verb = "rubs its antennae together"


surely could be more inventive for questions and exclamations?

Agreed, I will add more when I can see straight.

SamHPurp · 2017-06-29T09:43:23Z

code/modules/mob/language.dm

+	speech_verb = "rubs its antennae together"
+	ask_verb = "rubs its antennae together"
+	exclaim_verb = "rubs its antennae together"
+	colour = "kidan"


again, Kidan?

Again, way too tired

SamHPurp · 2017-06-29T09:46:22Z

@Birdtalon hah, we did that simultaneously.

Birdtalon · 2017-06-29T09:48:49Z

@SamHPurp Oh dear!

I have yet to see any arguments that this will benefit the server other than "I want." We already have plenty of unplayed and unloved races and adding yet another is not a good direction in my opinion when we I would like to see some focus on trying to make the existing unloved races appealing.

Fruerlund · 2017-06-29T09:52:40Z

Hmm. I think its an interesting tought.

The only dislikes I have is the coloring/shades of the /ears/ and wings. Not very good.

Perhaps as a possible solution to the wings is to have them /in/ by default and you can flip them instead

Kyep · 2017-06-29T09:56:49Z

Concerns:

How will these work with hardsuits?
What will be unique about them, beyond their looks?

I think its great to have more races, especially ones that look different. So long as they look good, don't break horribly in hardsuits, and have some uniqueness to their mechanics, I see no reason not to add them. Diversity is good.

shazbot194 · 2017-06-29T10:00:41Z

If the code is working right, I haven't tested it yet, all their external features should disappear when they wear a hardsuit, and since they have a smaller frame, they should fit into human hardsuits until custom ones can be made.

Spartan6 · 2017-06-29T10:18:01Z

I don't see any reason why they couldn't use human models for hardsuits, their wings can just fold easily enough.

Da-Dman234 · 2017-06-29T14:18:37Z

The ability to have them eat jumpsuits is... questionable? Not really comfortable with the idea of eating jumpsuits off of people, if that's what you mean. I understand that moth's eat clothes in real life but I just don't see what purpose that serves in-game.

I'm all for adding more stuff but for a new race I'd like some meaningful differences from what we already have currently, interesting idea though.

shazbot194 · 2017-06-29T16:58:19Z

If you are concerned about them eating jumpsuits, it would be the same how other people already eat food, in that you need to be holding the item in hand. And it's meant to more or less be a gimmick, kinda like how drasks can eat soap.

Spacemanspark · 2017-06-29T17:30:14Z

I'm really not sure how I feel about this.
The moth race was initially created on Aphelion, a now dead SS13 server. Hippie ported them as a joke because of how ridiculous they are.
I'm unsure if porting these is a good idea. I'm also not a fan of the sprites or colors.
On the other hand, as Kyet said, diversity is nice.

Fox-McCloud · 2017-06-29T17:47:43Z

Carry a flashlight, be human+

they take 10% brute damage reduction and their sole weakness is removed by having your PDA light on.

shazbot194 · 2017-06-29T17:57:09Z

I already tested it, the PDA flashlight is not enough to trigger them being normal speed.

Fox-McCloud · 2017-06-29T18:19:24Z

Regular flashlight probably will be (or will be in combination with the PDA light). The larger point is; it's not a real weakness.

shazbot194 · 2017-06-29T18:42:12Z

Ok, well, I have talked to Lasshy, we have decided to remove the armor buff. I also have added it so that they take a lot of tox damage from pest killer. I think this puts them out of the Vulp+ range, if they were ever in that range.

Yup, as the title says.

ghost · 2017-06-29T19:47:57Z

@shazbot194
I hope you know adding a entire new species takes way more work than just putting up a port PR and discussing it between two players because "I want." if you don't want to get it shot down by the entire playerbase.

The name for this species is just copy-pasted from the name of a IRL moth species and the entire species itself are just anthro moths, where is the creativity?
Is there even any lore to this species, at all?
Why would we need to port this? Is there anything this species adds to the server?

If you could adress these 3 things, that would be great.

Cactus2388 · 2017-06-29T23:30:26Z

I feel like it'd work better as a "Variation" of kidan.

shazbot194 · 2017-06-29T23:46:58Z

Well, after a lot of talks with several different people, this PR is going to be changed into adding in a variations of Kidans, starting with the moth, and expanding out from there. The current plan is to have them each share the base stats, but have one or two bonuses changed, for instance, the current Kidans have bio-luminescence, so instead of having that, the Moth Kidans can "fly" in zero G as long as there is air for them to do so.

Vivalas · 2017-06-30T00:36:24Z

Well, I suppose making them a subtype is.. okayish but don't know how that would work codewise or interface wise, seems a bit snowflakey for one race, unless there is a system for that.

I somewhat like the idea of moving around without gravity, since that is a unique racial ability, but still feel like the context of this PR is questionable.

I like the idea of kidan being more unique, maybe giving that ability to them would be neat.

MarcellusPye · 2017-06-30T00:43:53Z

I wonder how much work will be put in once the wings are merged.

Regen1 · 2017-06-30T03:27:06Z

Sorry, but those wings look absolutely horrible.

Dinarzad · 2017-06-30T05:08:16Z

I like the things being added here (Would play mothman) for the Kidan, but I think it might be better left to just be cosmetic only and not add any different functionality.

Think of it like normal IPCs and the "Human" IPC parts. It adds a new twist and lots of cosmetic variability on a race that could sorely use it, but doesn't have any of the balance concerns.
The only problem would be uhhh... why are some kidan ants and why are some moths, as a species.

FuryMcFlurry · 2017-06-30T11:15:58Z

@Spacemanspark creator and spriter of the mothman race here. I created mothmen after people were shitposting moths on /ss13g /, to taunt them I made them and got them added to hippie.

I am glad to see my little creation is getting ported to paradise. cant wait to see the fallout this creates.
If you guys have any questions or want my paint.net files feel free to msg me.

Rumiluntti · 2017-06-30T14:09:04Z

I still stand with my opinion to intentionally make them the shittiest race to ever walk the station.
Massive burn and brute weakness but on the upside, you get the most retarded scream in the game.

Hard mode/fool trap.

Citinited · 2017-06-30T19:51:31Z

code/modules/mob/language.dm

@@ -268,6 +268,17 @@
 	flags = RESTRICTED | WHITELISTED
 	syllables = list("click","clack")

+/datum/language/moth
+	name = "Gypsikin"
+	desc = "The noise made vibrating air inside hollow chanbers."


This sentence probably needs rewriting, or at least made gramatically correct.

chanbers 🤣

Exactly as the title says.

Citinited · 2017-06-30T22:13:16Z

code/modules/mob/language.dm

+	ask_verb = "buzzes"
+	exclaim_verb = "buzzes loudly"
+	colour = "moth"
+	key = "m"


Change this to something else e.g. mo as it interferes with medbay's radio channel

^

KasparoVy · 2017-06-30T22:52:12Z

I'm going to agree with Rumiluntti.
Also, 200kp.
Because I will play them anyway.

shazbot194 · 2017-06-30T23:20:22Z

Well, right now they are a sub species, which means that you can unlock them when you unlock Kidan. Although I can change their brute and burn mod, I have left it untouched as of right now and instead, have mostly swapped the Bio-luminescent with flying in 0G, providing mostly a cosmetic change with a small mechanical change.

now the layers all work correctly. This was done by having identifable words in the icon_state, so even though I wasn't able to get var info, I was able to somewhat cheese it

tigercat2000 · 2017-07-04T18:28:11Z

Following discussion between the Heads of Staff and Maintainers, it was decided to close this PR. Making moths a subspecies of Kidan is not seen as being a particularly interesting addition to the game, being little more than a resprite. In addition, it yet again touches on human/update_icons, further complicating something that is already a maintainability nightmare. Finally, it touches upon the subject of subspecies, which has absolutely no system attached, and would further complicate future maintainability.

Furthermore, adding a brand new race is a huge undertaking and, to be perfectly honest, we're simply not looking for more species at this moment; we'd rather work on the species we have now.

shazbot194 added 3 commits June 28, 2017 22:32

Ports Moths

1b76001

Ports Moths from Hippie. Will add more to the description to in a littlebit.

small icon fixes

97f7fbd

yes

Ready

243be6f

Ready to be shown

Birdtalon reviewed Jun 29, 2017

View reviewed changes

SamHPurp suggested changes Jun 29, 2017

View reviewed changes

tigercat2000 added the Feature This PR is a new addition to the game label Jun 29, 2017

Balance changes and small code fixes.

f0e06b0

Yup, as the title says.

shazbot194 changed the title ~~Adds in Moths [WIP]~~ Adds in Kidan variant, Moths [WIP] Jun 29, 2017

shazbot194 changed the title ~~Adds in Kidan variant, Moths [WIP]~~ Adds in Kidan variants [WIP] Jun 29, 2017

tigercat2000 added the Work In Progress This PR is work in progress, and unfinished label Jun 30, 2017

Citinited reviewed Jun 30, 2017

View reviewed changes

Makes moth a sub species, and add in a system to let that happen

c5e6405

Exactly as the title says.

Citinited reviewed Jun 30, 2017

View reviewed changes

Fixes a small typo and adds in a comment that wasn't saved

a4b366d

^

Adds in the last couple parts to the human update icon code

8ad0de3

now the layers all work correctly. This was done by having identifable words in the icon_state, so even though I wasn't able to get var info, I was able to somewhat cheese it

tigercat2000 closed this Jul 4, 2017

shazbot194 deleted the moth branch July 5, 2017 19:14

		light_amount = min(T.get_lumcount() * 10, 5) //hardcapped so it's not abused by having a ton of flashlights


		if((light_amount >= 5) && !H.suiciding) //if there's enough light, heal

Adds in Kidan variants [WIP] #7665

Adds in Kidan variants [WIP] #7665

Conversation

shazbot194 commented Jun 29, 2017 • edited

SamHPurp commented Jun 29, 2017 • edited

shazbot194 commented Jun 29, 2017 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SamHPurp left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SamHPurp commented Jun 29, 2017

Birdtalon commented Jun 29, 2017 • edited

Fruerlund commented Jun 29, 2017

Kyep commented Jun 29, 2017 • edited

shazbot194 commented Jun 29, 2017

Spartan6 commented Jun 29, 2017

Da-Dman234 commented Jun 29, 2017

shazbot194 commented Jun 29, 2017

Spacemanspark commented Jun 29, 2017

Fox-McCloud commented Jun 29, 2017

shazbot194 commented Jun 29, 2017

Fox-McCloud commented Jun 29, 2017

shazbot194 commented Jun 29, 2017

ghost commented Jun 29, 2017 • edited by ghost

Cactus2388 commented Jun 29, 2017

shazbot194 commented Jun 29, 2017 • edited

Vivalas commented Jun 30, 2017

MarcellusPye commented Jun 30, 2017 • edited

Regen1 commented Jun 30, 2017

Dinarzad commented Jun 30, 2017

FuryMcFlurry commented Jun 30, 2017

Rumiluntti commented Jun 30, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

KasparoVy commented Jun 30, 2017 • edited

shazbot194 commented Jun 30, 2017 • edited

tigercat2000 commented Jul 4, 2017

shazbot194 commented Jun 29, 2017 •

edited

SamHPurp commented Jun 29, 2017 •

edited

shazbot194 commented Jun 29, 2017 •

edited

Birdtalon commented Jun 29, 2017 •

edited

Kyep commented Jun 29, 2017 •

edited

ghost commented Jun 29, 2017 •

edited by ghost

shazbot194 commented Jun 29, 2017 •

edited

MarcellusPye commented Jun 30, 2017 •

edited

KasparoVy commented Jun 30, 2017 •

edited

shazbot194 commented Jun 30, 2017 •

edited