Don't crash upon reaching EndFile, or if observing properties. #6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you reach the end of the file-- e.g. by playing past the end-- the following assertion fails triggers a panic:
https://github.com/ParadoxSpiral/mpv-rs/blob/99853ac04dd8cb890cce0b98a1094c2b873600e0/src/wrapper/events/simple.rs#L198
I changed it to return
None
.Then it panics if it tries to observe a property change on an already-ended file because then the format is blank and the data is invalid. See:
https://github.com/ParadoxSpiral/mpv-rs/blob/99853ac04dd8cb890cce0b98a1094c2b873600e0/src/wrapper/events/simple.rs#L41
https://github.com/ParadoxSpiral/mpv-rs/blob/99853ac04dd8cb890cce0b98a1094c2b873600e0/mpv-sys/include/client.h#L1117-L1122
I patched that too, and now it no longer crashes when reaching the end of a file.