Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix index grid layout & disallow not-squared cover image uploading #29

Closed
wants to merge 4 commits into from

Conversation

fewwwww
Copy link
Contributor

@fewwwww fewwwww commented Feb 2, 2022

  • Display the index grid evenly, regardless of each row's height
  • Disallow cover images from being uploaded that are not perfectly square (1:1 aspect ratio)

fix bounty

@xylophonez
Copy link
Collaborator

@fewwwww - The index looks great!

Although, I was able to upload a show with an image that's not square. Unsure why, but isPodcastCoverSquared returns true for a rectangular image.

Maybe test by running the app locally but exiting from the handleShowUpload function as soon as the square check is done?

It would also be preferable to show the error to the user - if possible, before they submit the form.

@xylophonez
Copy link
Collaborator

For individual show view, this appears to introduce breaking changes as to the distance between the show header and episode list however:

before

after

@fewwwww
Copy link
Contributor Author

fewwwww commented Feb 3, 2022

For individual show view, this appears to introduce breaking changes as to the distance between the show header and episode list however:

before

after

Now I found a way to render the podcasts based on the max height of them. It should be all good with all devices.

I first render them in hidden visibility and auto height, then get the height of each podcast child, then pass back to index.js, then find the max of them, then render them in visible visibility and max height.

@xylophonez
Copy link
Collaborator

@fewwwww nice! the index view and individual show view looks awesome now. could you please make a new PR against main with just those fixes? we can merge those in right away and not depend on having the square image part done.

@fewwwww
Copy link
Contributor Author

fewwwww commented Feb 3, 2022

@fewwwww nice! the index view and individual show view looks awesome now. could you please make a new PR against main with just those fixes? we can merge those in right away and not depend on having the square image part done.

Alright, I will make two other pr for both commits

@fewwwww fewwwww closed this Feb 3, 2022
@xylophonez
Copy link
Collaborator

@fewwwww I just merged the still-open PRs, seems they cover:

  • remove the large gap between podcast_html header and episode list
  • disallow non-square cover images

... but not the actual layout fixes on the index grid view.

Would you be able to open a new PR with those? I think they got overlooked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants