Fix for bug where failed queue job is not removed

Parallels · Jul 7, 2016 · 4420314 · 4420314
1 parent 0a53fad
commit 4420314
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/rq_dashboard/web.py b/rq_dashboard/web.py
@@ -26,7 +26,7 @@
     Queue, Worker,
     cancel_job, get_failed_queue, pop_connection, push_connection, requeue_job
 )
-from rq.exceptions import NoSuchJobError
+from rq.exceptions import NoSuchJobError, InvalidJobOperationError
 from rq.job import JobStatus
 
 blueprint = Blueprint(
@@ -182,6 +182,8 @@ def requeue_and_double_job_view(job_id):
         raise NoSuchJobError(
             'Job {} does not exist in failed queue'.format(job_id)
         )
+    if fq.remove(job_id) == 0:
+        raise InvalidJobOperationError('Cannot requeue non-failed jobs')
     # Reset the job state
     job.set_status(JobStatus.QUEUED)
     job.exc_info = None