-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mapping for advancements
and client
packages
#288
base: versions/1.21.x
Are you sure you want to change the base?
Mapping for advancements
and client
packages
#288
Conversation
@@ -34,8 +34,8 @@ CLASS net/minecraft/client/renderer/LevelRenderer | |||
ARG 10 blue | |||
ARG 11 alpha | |||
METHOD addFrustumQuad (Lcom/mojang/blaze3d/vertex/VertexConsumer;Lorg/joml/Matrix4f;IIIIIII)V | |||
ARG 1 consumer | |||
ARG 2 matrix | |||
ARG 1 buffer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the change from consumer
to buffer
in these methods, since the type is VertexConsumer
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
buffer
is more correct. The VertexConsumer
is always sourced from MultiBufferSource.getBuffer()
and represents a buffer.
ARG 0 pose | ||
ARG 1 buffer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RE: Why the change from consumer
to buffer
for type VertexConsumer
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
buffer
is more correct. The VertexConsumer
is always sourced from MultiBufferSource.getBuffer()
and represents a buffer.
No description provided.