Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for running custom checks #129

Merged
merged 2 commits into from
Aug 22, 2022
Merged

Add support for running custom checks #129

merged 2 commits into from
Aug 22, 2022

Conversation

dz0ny
Copy link
Member

@dz0ny dz0ny commented Aug 18, 2022

ref: #128
ref: https://github.com/teamniteo/pareto/issues/396

Custom checks are shown under My Checks claim
image
and they follow usnistgov yaml spec, they need to be enabled under Preferences (disabled by default as there are two Security prompts issued by macOS)
image

@dz0ny dz0ny requested a review from zupo August 18, 2022 16:30
@github-actions
Copy link

You can find the built app under the Artifacts at https://github.com/ParetoSecurity/pareto-mac/actions/runs/2883915675

@github-actions
Copy link

You can find the app screenshots under the Artifacts at https://github.com/ParetoSecurity/pareto-mac/actions/runs/2883915675

@codecov
Copy link

codecov bot commented Aug 18, 2022

Codecov Report

Merging #129 (d77295e) into main (c43d593) will increase coverage by 0.04%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #129      +/-   ##
==========================================
+ Coverage   16.59%   16.64%   +0.04%     
==========================================
  Files         104      104              
  Lines        3163     3136      -27     
==========================================
- Hits          525      522       -3     
+ Misses       2638     2614      -24     
Impacted Files Coverage Δ
Pareto/Checks/Checks.swift 100.00% <ø> (ø)
Pareto/Defaults.swift 75.00% <ø> (+25.00%) ⬆️
Pareto/Utils.swift 0.00% <0.00%> (ø)
Pareto/Views/Settings/AboutSettingsView.swift 0.00% <0.00%> (ø)
Pareto/Views/Settings/GeneralSettingsView.swift 0.00% <0.00%> (ø)
ParetoSecurityTests/SettingsTests.swift 0.00% <0.00%> (ø)
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link

You can find the built app under the Artifacts at https://github.com/ParetoSecurity/pareto-mac/actions/runs/2902858963

Copy link
Member

@zupo zupo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would call them Additional Checks, otherwise it is good.

@github-actions
Copy link

You can find the built app under the Artifacts at https://github.com/ParetoSecurity/pareto-mac/actions/runs/2903314010

1 similar comment
@github-actions
Copy link

You can find the built app under the Artifacts at https://github.com/ParetoSecurity/pareto-mac/actions/runs/2903314010

@github-actions
Copy link

You can find the app screenshots under the Artifacts at https://github.com/ParetoSecurity/pareto-mac/actions/runs/2903314010

@dz0ny dz0ny merged commit 4066a77 into main Aug 22, 2022
@dz0ny dz0ny deleted the add/custom-check branch August 22, 2022 11:21
@github-actions
Copy link

You can find the built app under the Artifacts at https://github.com/ParetoSecurity/pareto-mac/actions/runs/2903461674

@github-actions
Copy link

You can find the app screenshots under the Artifacts at https://github.com/ParetoSecurity/pareto-mac/actions/runs/2903461674

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants