Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new update UI #44

Merged
merged 1 commit into from
Sep 3, 2021
Merged

Add new update UI #44

merged 1 commit into from
Sep 3, 2021

Conversation

dz0ny
Copy link
Member

@dz0ny dz0ny commented Sep 3, 2021

update.mov

Closes #43

@github-actions
Copy link

github-actions bot commented Sep 3, 2021

Download the artifacts for this pull request:

For installing please follow the instructions detailed at If you want to open an app that hasn’t been notarized or is from an unidentified developer.

@github-actions
Copy link

github-actions bot commented Sep 3, 2021

You can find the app screenshots under the Artifacts at https://github.com/ParetoSecurity/pareto-mac/actions/runs/1197350702

@github-actions
Copy link

github-actions bot commented Sep 3, 2021

You can find the built app under the Artifacts at https://github.com/ParetoSecurity/pareto-mac/actions/runs/1197376278

@github-actions
Copy link

github-actions bot commented Sep 3, 2021

You can find the built app under the Artifacts at https://github.com/ParetoSecurity/pareto-mac/actions/runs/1197383993

@github-actions
Copy link

github-actions bot commented Sep 3, 2021

You can find the app screenshots under the Artifacts at https://github.com/ParetoSecurity/pareto-mac/actions/runs/1197376279

@codecov
Copy link

codecov bot commented Sep 3, 2021

Codecov Report

Merging #44 (ffa615c) into main (2fae0cc) will decrease coverage by 5.15%.
The diff coverage is 12.23%.

❗ Current head ffa615c differs from pull request most recent head b627471. Consider uploading reports for the commit b627471 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main      #44      +/-   ##
==========================================
- Coverage   63.25%   58.09%   -5.16%     
==========================================
  Files          30       29       -1     
  Lines         841      926      +85     
==========================================
+ Hits          532      538       +6     
- Misses        309      388      +79     
Impacted Files Coverage Δ
Pareto/ParetoApp.swift 32.20% <0.00%> (+6.64%) ⬆️
Pareto/StatusBar/StatusBarController.swift 75.55% <ø> (-0.79%) ⬇️
Pareto/Views/SpinnerView.swift 4.16% <4.16%> (ø)
Pareto/Views/SettingsView.swift 37.93% <22.85%> (-12.98%) ⬇️
ParetoSecurityTests/SettingsTests.swift 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2fae0cc...b627471. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Sep 3, 2021

You can find the app screenshots under the Artifacts at https://github.com/ParetoSecurity/pareto-mac/actions/runs/1197383990

@github-actions
Copy link

github-actions bot commented Sep 3, 2021

You can find the built app under the Artifacts at https://github.com/ParetoSecurity/pareto-mac/actions/runs/1197419231

@github-actions
Copy link

github-actions bot commented Sep 3, 2021

You can find the app screenshots under the Artifacts at https://github.com/ParetoSecurity/pareto-mac/actions/runs/1197419230

Copy link
Contributor

@dmurko dmurko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@github-actions
Copy link

github-actions bot commented Sep 3, 2021

You can find the built app under the Artifacts at https://github.com/ParetoSecurity/pareto-mac/actions/runs/1197481434

@github-actions
Copy link

github-actions bot commented Sep 3, 2021

You can find the app screenshots under the Artifacts at https://github.com/ParetoSecurity/pareto-mac/actions/runs/1197481432

@dz0ny dz0ny merged commit 7f7f2ad into main Sep 3, 2021
@dz0ny dz0ny deleted the add/new-update-ui branch September 3, 2021 09:41
@github-actions
Copy link

github-actions bot commented Sep 3, 2021

You can find the built app under the Artifacts at https://github.com/ParetoSecurity/pareto-mac/actions/runs/1197517024

@github-actions
Copy link

github-actions bot commented Sep 3, 2021

You can find the app screenshots under the Artifacts at https://github.com/ParetoSecurity/pareto-mac/actions/runs/1197517021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: No visible feedback if the app is updating/already updated
2 participants