maxCarryWeight can't be set below 512

[necanthrope]

Greetings, and thank you for an excellent mod :)

I'm trying to configure the maxCarryWeight property to be a value below 512, in this case 64. If I stop my server, set the value to 64, and then restart it, the max carry weight listed in F3 is still 512. The config file value doesn't change, so it's as if it's ignoring it.

I'll happily include my config file, but it's the one generated by the mod. I'm running this mod file:
IguanaTweaks-1.7.10-Beta-19.jar

[Parker8283]

Pastebin the modified one.

[necanthrope]

Certainly, here it is.

http://pastebin.com/40n04vYV

[Parker8283]

Nothing funky there. I'll have to test that later and figure out what's going on.

[necanthrope]

Thank you :)

[necanthrope]

Hey, I don't know if you've had a chance to look at this, but I also noticed that changing the rockWeight value in config also has no impact on encumbrance or total weight carried.

[necanthrope]

I'm starting to think I messed something up. My install is ignoring the values in weights.json, as well.
I have these values configured, but having one of the items in my inventory doesn't add the configured weight.

[minecraft@orbital IguanaTweaks]$ more weights.json
[
        {
                "block": "minecraft:lava_bucket",
                "weight" : "256"
        } ,
        {
                "block": "minecraft:milk_bucket",
                "weight" : "256"
        } ,
        {
                "block": "minecraft:water_bucket",
                "weight" : "256"
        } ,
        {
                "block": "thirstmod:item.clean_bucket",
                "weight" : "256"
        }
]

[Parker8283]

No, I haven't had a chance to look at it. I haven't had a chance to do
anything MC modding wise for a while. I've been bogged down by a lot of
real life stuff.

Also, the weight system is ready buggy. I have plans to rewrite it when I
get the chance.
On Dec 13, 2014 4:31 AM, "necanthrope" notifications@github.com wrote:

I'm starting to think I messed something up. My install is ignoring the
values in weights.json, as well.
I have these values configured, but having one of the items in my
inventory doesn't change the weight.

[minecraft@orbital IguanaTweaks]$ more weights.json
[
{
"block": "minecraft:lava_bucket",
"weight" : "256"
} ,
{
"block": "minecraft:milk_bucket",
"weight" : "256"
} ,
{
"block": "minecraft:water_bucket",
"weight" : "256"
} ,
{
"block": "thirstmod:item.clean_bucket",
"weight" : "256"
}
]

—
Reply to this email directly or view it on GitHub
#32 (comment)
.

[necanthrope]

I hear ya. :) I was just adding more info, not trying to prod you. :D

I may check out your project and poke around, if that's cool.

[Parker8283]

Well, it is an open source project, so I can't stop ya :P
On Dec 13, 2014 3:27 PM, "necanthrope" notifications@github.com wrote:

I hear ya. :) I was just adding more info, not trying to prod you. :D

I may check out your project and poke around, if that's cool.

—
Reply to this email directly or view it on GitHub
#32 (comment)
.

[necanthrope]

Good news, I think I resolved both of those behaviors. I'm doing testing now, when I'm done I'll post docs and submit a pull request.

[drago87]

is having the same problem. also using beta-19 well i hope you get it sorted loving it

[Parker8283]

The weight system should be less derpy in the repo. Need to do a few more tests before making a build.

[necanthrope]

The problem I was having is that in server scenarios, the mod was ignoring the server config and using its own. That's a problem for the server I am running. I have a functional fix for it, where if it's in a remote server situation, it sends a message to the client with the config data. Are you interested in a push request with this functionality?

[Parker8283]

A good server mod pack makes sure that the configs on both sides are the same. Anyways, I can't stop you making a pull request.

[necanthrope]

Yeah, but if you're not interested, there's no point in making one. :)

In the environment you describe (making sure the configs match), what should the system do if there's a discrepancy? What config takes precedence?

[Parker8283]

Generally, the servers should. Because if the clients did, then they could just revert all the tweaks made. It should be the servers that takes precedence. However, you don't want to change the content of the clients config files through code when they connect to a server. I do know how to implement this properly, though a PR would help, as makes less work for me :P

[necanthrope]

Oh, well that's perfect then; the change I put in doesn't alter the local config if it's different, it just ignores it in favor of the server config. Looks like we're on the same page after all.

[Parker8283]

Ok, so the maxCarryWeight is fine, but I believe that this issue is more of "Server config isn't syncing to Client." I will open up a new issue on that.