Fix the order of assignment of the NBFIX terms. #1122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I used the topology converted from PSF to the gromacs format but the simulation crashed, and after checking the topology file I found the epsilon and sigma were wrong. It seems PR ParmEd#1094 only partially changed the order of assignment of NBFIX. This commit should fix the issue.
|
Thanks! |
umesh-timalsina
added a commit
to mosdef-hub/mbuild
that referenced
this pull request
Feb 9, 2021
See ParmEd/ParmEd#1122 for the order change of the `nbfix_types` in newer version of parmed.
umesh-timalsina
added a commit
to mosdef-hub/mbuild
that referenced
this pull request
Feb 10, 2021
* Update nbfix changes in parmed See ParmEd/ParmEd#1122 for the order change of the `nbfix_types` in newer version of parmed. * WIP- Pin parmed version
umesh-timalsina
added a commit
to mosdef-hub/molbox
that referenced
this pull request
Jun 26, 2021
* Update nbfix changes in parmed See ParmEd/ParmEd#1122 for the order change of the `nbfix_types` in newer version of parmed. * WIP- Pin parmed version
umesh-timalsina
added a commit
to GOMC-WSU/MoSDeF-GOMC
that referenced
this pull request
Mar 22, 2022
* Update nbfix changes in parmed See ParmEd/ParmEd#1122 for the order change of the `nbfix_types` in newer version of parmed. * WIP- Pin parmed version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used the topology converted from PSF to the gromacs format but the
simulation crashed, and after checking the topology file I found the
epsilon and sigma were wrong. It seems PR #1097 only partially changed
the order of assignment of NBFIX. This commit should fix the issue.