Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added better reporting on recompute failure #207

Merged

Conversation

mristin
Copy link
Collaborator

@mristin mristin commented Apr 3, 2021

If the recomputation of a failed condition raised an exception, the user
was left in the dark which condition triggered the exception.

This patch adds a more informative message, so that the user can at
least inspect the problematic condition or send us a better bug report.

If the recomputation of a failed condition raised an exception, the user
was left in the dark which condition triggered the exception.

This patch adds a more informative message, so that the user can at
least inspect the problematic condition or send us a better bug report.
@mristin mristin force-pushed the mristin/Added-better-reporting-on-recompute-failure branch from 1d428a2 to 7220327 Compare April 3, 2021 21:56
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 93.899% when pulling 7220327 on mristin/Added-better-reporting-on-recompute-failure into d890e54 on master.

@mristin mristin merged commit d566488 into master Apr 3, 2021
@mristin mristin deleted the mristin/Added-better-reporting-on-recompute-failure branch April 3, 2021 22:00
mristin added a commit that referenced this pull request Apr 23, 2021
* Allowed `__new__` to tighten pre-conditions (#211)
* Fixed recomputation of calls in generator expr (#210)
* Added better reporting on recompute failure (#207)
@mristin mristin mentioned this pull request Apr 23, 2021
mristin added a commit that referenced this pull request Apr 23, 2021
* Allowed `__new__` to tighten pre-conditions (#211)
* Fixed recomputation of calls in generator expr (#210)
* Added better reporting on recompute failure (#207)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants