Fixed representation of numpy arrays #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The numpy arrays do not like `PLACEHOLDER in arr` which will cause a `ValueError`. However, we tested for `PLACEHOLDER` everywhere using `in` operator in the representation module. This patch fixes the problem by using explicit `any(...)` and checking also explicitly for `... is PLACEHOLDER`. In contrast, `in` operator uses equality (`==`) instead of identity (`is`), which was not the desirable behavior anyhow originally. Fixes #229.
mristin
force-pushed
the
mristin/Fixed-representation-of-numpy-arrays
branch
from
b9beb43
to
bfc4717
Compare
Merged
mristin
added a commit
that referenced
this pull request
Sep 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The numpy arrays do not like
PLACEHOLDER in arrwhich will cause aValueError. However, we tested forPLACEHOLDEReverywhere usinginoperator in the representation module.This patch fixes the problem by using explicit
any(...)and checkingalso explicitly for
... is PLACEHOLDER. In contrast,inoperatoruses equality (
==) instead of identity (is), which was not thedesirable behavior anyhow originally.
Fixes #229.