Tested for data classes with fields #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this patch, we test for `dataclasses` which use `field`'s to define default values. Originally, we thought that there are issues with data classes in general due to the issue #288, but it turned out that the order of decorators matters (``dataclass`` first). We tested everything, and documented the order of the decorators accordingly. Fixes #288.
mristin
force-pushed
the
mristin/Fixed-for-data-classes
branch
from
89c7583
to
5b1ba1e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this patch, we test for
dataclasseswhich usefield's to define default values. Originally, we thought that there are issues with data classes in general due to the issue #288, but it turned out that the order of decorators matters (dataclassfirst).We tested everything, and documented the order of the decorators accordingly.
Fixes #288.