Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

made graceful read and parse failures #24

Merged
merged 1 commit into from Aug 25, 2020

Conversation

mristin
Copy link
Collaborator

@mristin mristin commented Aug 25, 2020

Running pyicontract-lint against the repository telereddit made
it fail with an exception. This change handles most of the failures
gracefully returning a human-readable error message with extra
information.

This is related to #21.

@coveralls
Copy link

coveralls commented Aug 25, 2020

Pull Request Test Coverage Report for Build 92

  • 21 of 23 (91.3%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 91.409%

Changes Missing Coverage Covered Lines Changed/Added Lines %
icontract_lint/init.py 21 23 91.3%
Totals Coverage Status
Change from base Build 88: -0.2%
Covered Lines: 266
Relevant Lines: 291

💛 - Coveralls

Running pyicontract-lint against the repository [telereddit][1] made
it fail with an exception. This change handles most of the failures
gracefully returning a human-readable error message with extra
information.

This is related to #21.

[1]: https://github.com/fabiosangregorio/telereddit
@mristin mristin force-pushed the mristin/Made-graceful-read-and-parse-failures branch from da353c4 to 3711fbe Compare August 25, 2020 18:33
@mristin mristin merged commit 388bc70 into master Aug 25, 2020
@mristin mristin deleted the mristin/Made-graceful-read-and-parse-failures branch August 25, 2020 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants