Copy CSeq even if 0 #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the RTSP spec (RFC 7826), the initial sequence number is recommended to be 0: "The initial sequence number can be any number; however, it is RECOMMENDED to start at 0." The RTSP implementation in GStreamer's gst-plugins-base follows this recommendation[0], unlike LibVLC which seems to start at 2. Due to this bug, GStreamer can't be used to process the Anafi's video stream as it will refuse to parse a response to its initial OPTIONS request that doesn't include a CSeq header field. 0 = https://github.com/GStreamer/gst-plugins-base/blob/master/gst-libs/gst/rtsp/gstrtspconnection.c#L365
|
If this PR is accepted, I would appreciate if this finds its way into an Anafi firmware update quickly to fix compatibility with GStreamer-based applications. |
|
Ticket with GStreamer on request from their devs: https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/issues/624 |
|
Any updates? |
|
Hi, An equivalent patch was made on our side and merged in the 1.0.1 release of GroundSDK (37f0531#diff-0b46d09df402c1d49c089fa2dd669741) The fix is present on Anafi 1.6.0 and newer firmwares. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the RTSP spec (RFC 7826), the initial sequence
number is recommended to be 0:
"The initial sequence number can be any number; however, it is
RECOMMENDED to start at 0."
The RTSP implementation in GStreamer's gst-plugins-base follows
this recommendation[0], unlike LibVLC which seems to start at 2.
Due to this bug, GStreamer can't be used to process the Anafi's
video stream as it will refuse to parse a response to its
initial OPTIONS request that doesn't include a CSeq header field.
0 = https://github.com/GStreamer/gst-plugins-base/blob/master/gst-libs/gst/rtsp/gstrtspconnection.c#L365