Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes bug related to subqueries on unfetched objects #1046

Merged
merged 3 commits into from
Mar 15, 2016
Merged

Fixes bug related to subqueries on unfetched objects #1046

merged 3 commits into from
Mar 15, 2016

Conversation

flovilmart
Copy link
Contributor

fixes #1014

@facebook-github-bot
Copy link

@flovilmart updated the pull request.

@flovilmart flovilmart changed the title adds failing test for resolution Fixes #1014 related to subqueries on unfetched objects Mar 15, 2016
flovilmart
flovilmart reviewed Mar 15, 2016
View reviewed changes
src/RestQuery.js
return subquery.execute().then((response) => {
var values = [];
for (var result of response.results) {
values.push({
__type: 'Pointer',
className: notInQueryValue.className,
className: subquery.className,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use the subquery.className as it may have been mutated by redirectClassNameForKey

@codecov-io
Copy link

Current coverage is 91.64%

Merging #1046 into master will not affect coverage as of 4758239

@@            master   #1046   diff @@
======================================
  Files           73      73       
  Stmts         4438    4442     +4
  Branches       889     889       
  Methods          0       0       
======================================
+ Hit           4067    4071     +4
  Partial         10      10       
  Missed         361     361

Review entire Coverage Diff as of 4758239

Powered by Codecov. Updated on successful CI builds.

@flovilmart flovilmart changed the title Fixes #1014 related to subqueries on unfetched objects Fixes bug related to subqueries on unfetched objects Mar 15, 2016
@facebook-github-bot
Copy link

@flovilmart updated the pull request.

flovilmart added a commit that referenced this pull request Mar 15, 2016
@flovilmart
Merge pull request #1046 from ParsePlatform/flovilmart.fix1014
9ea344a 
Fixes bug related to subqueries on unfetched objects
@flovilmart flovilmart merged commit 9ea344a into master Mar 15, 2016
@flovilmart flovilmart deleted the flovilmart.fix1014 branch March 15, 2016 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

matchesQuery on relation query always finds zero objects
4 participants
@flovilmart @facebook-github-bot @codecov-io @gfosco