Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows Operations on Roles #1068

Merged
merged 1 commit into from
Mar 17, 2016
Merged

Allows Operations on Roles #1068

merged 1 commit into from
Mar 17, 2016

Conversation

flovilmart
Copy link
Contributor

Now that roles are protected by a required ACL upon creation, we can skip the added security.

see: here, here, here

@codecov-io
Copy link

Current coverage is 91.68%

Merging #1068 into master will increase coverage by +0.02% as of 9b4f61c

@@            master   #1068   diff @@
======================================
  Files           74      74       
  Stmts         4452    4450     -2
  Branches       890     889     -1
  Methods          0       0       
======================================
- Hit           4081    4080     -1
  Partial         10      10       
+ Missed         361     360     -1

Review entire Coverage Diff as of 9b4f61c

Powered by Codecov. Updated on successful CI builds.

@nlutsenko
Copy link
Contributor

Lgtm, but since it's security related I need a second opinion.

@drew-gross
Copy link
Contributor

Your links broke but I think I figured out what they were supposed to be pointing at. LGTM too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants