do not override username #1142

flovilmart · 2016-03-23T01:19:22Z

codecov-io · 2016-03-23T01:26:21Z

Current coverage is `91.85%`

Merging #1142 into master will not affect coverage as of 9441203

@@            master   #1142   diff @@
======================================
  Files           92      92       
  Stmts         5808    5807     -1
  Branches      1056    1056       
  Methods          0       0       
======================================
- Hit           5335    5334     -1
  Partial         11      11       
  Missed         462     462

Review entire Coverage Diff as of 9441203

Powered by Codecov. Updated on successful CI builds.

flovilmart · 2016-03-23T01:32:36Z

src/RestWrite.js

@@ -281,26 +281,26 @@ RestWrite.prototype.handleAuthData = function(authData) {

    this.storage['authProvider'] = Object.keys(authData).join(',');

-    if (results.length == 0) {
-      this.data.username = cryptoUtils.newToken();


just needed to remove that so we don't override username when we have no results

lolobosse · 2016-03-23T11:52:12Z

I can confirm, made it running and it solved my bug. GG @flovilmart

What is the usual time for release of such a fix?

flovilmart · 2016-03-23T11:53:04Z

This has been merged to master, that will go to the next release, (we just released yesterday).
Do you deploy your app remotely? on heroku? What does your folder structure look like?

lolobosse · 2016-03-23T15:15:21Z

I host myself and use Parse-example basically.

To test your code, I patched (dirty) the bin folder 😆

flovilmart · 2016-03-23T15:17:20Z

ok good

do not override username

b30805b

flovilmart reviewed Mar 23, 2016
View reviewed changes

drew-gross added the GH Review: accepted label Mar 23, 2016

flovilmart merged commit 3ce634b into master Mar 23, 2016

flovilmart deleted the flovilmart.fixes1136 branch March 23, 2016 11:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

do not override username #1142

do not override username #1142

flovilmart commented Mar 23, 2016

codecov-io commented Mar 23, 2016

flovilmart Mar 23, 2016

lolobosse commented Mar 23, 2016

flovilmart commented Mar 23, 2016

lolobosse commented Mar 23, 2016

flovilmart commented Mar 23, 2016

do not override username #1142

do not override username #1142

Conversation

flovilmart commented Mar 23, 2016

codecov-io commented Mar 23, 2016

Current coverage is 91.85%

flovilmart Mar 23, 2016

Choose a reason for hiding this comment

lolobosse commented Mar 23, 2016

flovilmart commented Mar 23, 2016

lolobosse commented Mar 23, 2016

flovilmart commented Mar 23, 2016

Current coverage is `91.85%`