Fixes #1417

[drew-gross]

Pretty ugly solution but it does the trick.

[flovilmart]

why don't we do something like

if (isNestedObject) {
   let transformableKeys = ["_id", ...];
   Object.keys(mongoObject).forEach((key) => {
     if (transformableKeys.indexOf(key) > -1) {
       restObject[key] = untransformObject(schema, className, mongoObject[key], true);
     } else {
       restObject[key] = mongoObject[key];
     }
  });
  return restObject;
}

[drew-gross]

Yeah I will refactor

[flovilmart]

maybe move let transformableKeys some where else, and if we get crazy we could have a structure like:

transformKey: {
   key: {
       nested: (key, mongoObject, restObject) => {
           // to the mongoObjectTransform and assign on restObject
       },
       default: (key, mongoObject, restObject) => {
           // to the mongoObjectTransform and assign on restObject
       },
   }
}

[drew-gross]

I went with something simpler. Moving this logic all to the mongo adapter will be a better time to fix it up.

[facebook-github-bot]

@drew-gross updated the pull request.

[blacha]

should switch these two statements around so the if will exit early with the boolean compare rather than a Object key iteration

if(isNestedObject && _.includes(specialKeys, key)) {
    // ...
}

[drew-gross]

Good idea! Thanks.

[facebook-github-bot]

@drew-gross updated the pull request.

[drew-gross]

Hmmm travis isn't picking up this commit....

[blacha]

It also missed building #1416

[drew-gross]

Whoops. Guess we better not do a release until we get passing tests.

[flovilmart]

meh...

[codecov-io]

Current coverage is 92.77%

Merging #1420 into master will decrease coverage by -0.02% as of 4949738

@@            master   #1420   diff @@
======================================
  Files           87      87       
  Stmts         5479    5483     +4
  Branches      1011    1012     +1
  Methods          0       0       
======================================
+ Hit           5084    5087     +3
  Partial         10      10       
- Missed         385     386     +1

Review entire Coverage Diff as of 4949738

Powered by Codecov. Updated on successful CI builds.

[flovilmart]

should we move that up? I don't think that behaves as a static in Obj-C

[blacha]

If babel is anything like typescript that would just be converted to var specialKeys

So ideally this should be declared outside of the function, or at the very least outside of the loop.

[facebook-github-bot]

@drew-gross updated the pull request.

[flovilmart]

can you throw in a regular key there? (see the other comment)

[drew-gross]

Passed locally even with regular keys

[facebook-github-bot]

@drew-gross updated the pull request.

[flovilmart]

Merging then!