Removing sessionToken and authData from _User objects included in a query

[simonas-notcat]

This bug caused sessionToken to be replaced on client side to some old
sessionToken from DB.

There was a similar issue discussed here: #373 , but the proposed fix had a bug in it.

[flovilmart]

Good catch! Thanks for the PR! Can you add a unit test to prevent subsequent regressions?

[simonas-notcat]

Sorry, but I'm not sure how to write a test for that. I was having problems with users, that were migrated from Parse.com.

Anyway, I've already spent to much time on this issue... :(

[flovilmart]

If you had to make a fix, that means there was an error somehow. The unit test will make sure subsequent refactoring don't resurface that error. Without it, that's really problematic for us, as we won't be able to make sure your fix and the behaviour it introduces can be properly maintain over time.

[codecov-io]

Current coverage is 92.81%

Merging #1450 into master will increase coverage by +0.04% as of eabdb9a

@@            master   #1450   diff @@
======================================
  Files           87      87       
  Stmts         5483    5485     +2
  Branches      1012    1013     +1
  Methods          0       0       
======================================
+ Hit           5087    5091     +4
  Partial         10      10       
+ Missed         386     384     -2

Review entire Coverage Diff as of eabdb9a

Powered by Codecov. Updated on successful CI builds.

[flovilmart]

One small nit, can you remove https://github.com/ParsePlatform/parse-server/pull/1450/files#diff-dc168077f7f927cefd5df84cb82228a6R453 var className = null;

[simonas-notcat]

I don't understand where this line comes from. I can't see it here:
acb294d
simonas-notcat@acb294d

[flovilmart]

it's line 453 of the same file

[simonas-notcat]

@flovilmart take a look at this https://s3-eu-west-1.amazonaws.com/emctmp/github_magic.mov

[flovilmart]

when you opened the link a line what highlighted in yellow, that's a variable that don't seems to be used anywhere.

[flovilmart]

[simonas-notcat]

@flovilmart I can see that line only when I open your link. But when I change Diff view options, it disappears (thats what I tried to show you in my video). Also, I can't see that line in my commit.

[flovilmart]

You didn't changed that line, I'm asking you to remove it as it's unused.

[simonas-notcat]

I feel that there is some kind of miscommunication going on. I'm trying to tell you that I did not commit that line. Please open this link and take a look for your self: simonas-notcat@acb294d?diff=unified

[flovilmart]

I know you did not commit that line, I'm asking you to remove it as you removed the reference to className in your commit and we have a dangling variable that is never used.

[facebook-github-bot]

@simonas-notcat updated the pull request.

[simonas-notcat]

@flovilmart I think yesterday I was too tired to figure out what you were asking :). Hope now it's ok

[flovilmart]

Yeah that's great! Thanks