LiveQuery constrains matching fix #2357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uery This bug caused sessionToken to be replaced on client side to some old sessionToken from DB.
If there is a liveQuery subscription, with Pointer type constrains (e.g
query.equalTo('user', Parse.User.current())), and new object has
undefined value for that field, we get this error:
error: Uncaught internal server error. [TypeError: Cannot read
property 'className' of undefined] TypeError: Cannot read property
'className' of undefined
at matchesKeyConstraints
(…/node_modules/parse-server/lib/LiveQuery/QueryTools.js:145:51)
When constrains == null, we get “Uncaught internal server error”
Current coverage is 91.80% (diff: 100%)@@ master #2357 diff @@
==========================================
Files 94 94
Lines 10479 10483 +4
Methods 1275 1275
Messages 0 0
Branches 1713 1714 +1
==========================================
+ Hits 9621 9624 +3
- Misses 858 859 +1
Partials 0 0
|
rsouzas
pushed a commit
to back4app/parse-server
that referenced
this pull request
Mar 15, 2017
* Removing sessionToken and authData from _User objects included in a query
This bug caused sessionToken to be replaced on client side to some old
sessionToken from DB.
* Removing dangling variable that is never used
* Checking if object has defined key for Pointer constraints in liveQuery
If there is a liveQuery subscription, with Pointer type constrains (e.g
query.equalTo('user', Parse.User.current())), and new object has
undefined value for that field, we get this error:
error: Uncaught internal server error. [TypeError: Cannot read
property 'className' of undefined] TypeError: Cannot read property
'className' of undefined
at matchesKeyConstraints
(…/node_modules/parse-server/lib/LiveQuery/QueryTools.js:145:51)
* LiveQuery constrains matching fix
When constrains == null, we get “Uncaught internal server error”
rsouzas
pushed a commit
to back4app/parse-server
that referenced
this pull request
Mar 16, 2017
* Removing sessionToken and authData from _User objects included in a query
This bug caused sessionToken to be replaced on client side to some old
sessionToken from DB.
* Removing dangling variable that is never used
* Checking if object has defined key for Pointer constraints in liveQuery
If there is a liveQuery subscription, with Pointer type constrains (e.g
query.equalTo('user', Parse.User.current())), and new object has
undefined value for that field, we get this error:
error: Uncaught internal server error. [TypeError: Cannot read
property 'className' of undefined] TypeError: Cannot read property
'className' of undefined
at matchesKeyConstraints
(…/node_modules/parse-server/lib/LiveQuery/QueryTools.js:145:51)
* LiveQuery constrains matching fix
When constrains == null, we get “Uncaught internal server error”
This was referenced Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When constrains == null, we get “Uncaught internal server error”
Uncaught internal server error. TypeError: Cannot read property '__type' of null
at matchesKeyConstraints (/project/node_modules/parse-server/lib/LiveQuery/QueryTools.js:143:18)
at matchesQuery (/project/node_modules/parse-server/lib/LiveQuery/QueryTools.js:111:10)
at ParseLiveQueryServer._matchesSubscription (/project/node_modules/parse-server/lib/LiveQuery/ParseLiveQueryServer.js:536:43)
at _loop3 (/project/node_modules/parse-server/lib/LiveQuery/ParseLiveQueryServer.js:310:53)
at ParseLiveQueryServer._onAfterSave (/project/node_modules/parse-server/lib/LiveQuery/ParseLiveQueryServer.js:422:11)
at Subscriber. (/project/node_modules/parse-server/lib/LiveQuery/ParseLiveQueryServer.js:118:15)
at emitTwo (events.js:106:13)
at Subscriber.emit (events.js:191:7)
at EventEmitter.handler (/project/node_modules/parse-server/lib/LiveQuery/EventEmitterPubSub.js:60:16)
at emitOne (events.js:96:13)
at EventEmitter.emit (events.js:188:7) TypeError: Cannot read property '__type' of null
at matchesKeyConstraints (/project/node_modules/parse-server/lib/LiveQuery/QueryTools.js:143:18)
at matchesQuery (/project/node_modules/parse-server/lib/LiveQuery/QueryTools.js:111:10)
at ParseLiveQueryServer._matchesSubscription (/project/node_modules/parse-server/lib/LiveQuery/ParseLiveQueryServer.js:536:43)
at _loop3 (/project/node_modules/parse-server/lib/LiveQuery/ParseLiveQueryServer.js:310:53)
at ParseLiveQueryServer._onAfterSave (/project/node_modules/parse-server/lib/LiveQuery/ParseLiveQueryServer.js:422:11)
at Subscriber. (/project/node_modules/parse-server/lib/LiveQuery/ParseLiveQueryServer.js:118:15)
at emitTwo (events.js:106:13)
at Subscriber.emit (events.js:191:7)
at EventEmitter.handler (/project/node_modules/parse-server/lib/LiveQuery/EventEmitterPubSub.js:60:16)
at emitOne (events.js:96:13)
at EventEmitter.emit (events.js:188:7)