Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds liniting into the workflow #3082

Merged
merged 9 commits into from Nov 24, 2016
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/authDataManager/qq.js
Expand Up @@ -13,7 +13,7 @@ function validateAuthData(authData) {
}

// Returns a promise that fulfills if this app id is valid.
function validateAppId(appIds, authData) {
function validateAppId() {
return Promise.resolve();
}

Expand All @@ -35,7 +35,7 @@ function graphRequest(path) {
data = JSON.parse(data);
resolve(data);
});
}).on('error', function (e) {
}).on('error', function () {
reject('Failed to validate this access token with qq.');
});
});
Expand Down
4 changes: 2 additions & 2 deletions src/authDataManager/wechat.js
Expand Up @@ -13,7 +13,7 @@ function validateAuthData(authData) {
}

// Returns a promise that fulfills if this app id is valid.
function validateAppId(appIds, authData) {
function validateAppId() {
return Promise.resolve();
}

Expand All @@ -29,7 +29,7 @@ function graphRequest(path) {
data = JSON.parse(data);
resolve(data);
});
}).on('error', function (e) {
}).on('error', function () {
reject('Failed to validate this access token with weixin.');
});
});
Expand Down
6 changes: 3 additions & 3 deletions src/authDataManager/weibo.js
Expand Up @@ -14,7 +14,7 @@ function validateAuthData(authData) {
}

// Returns a promise that fulfills if this app id is valid.
function validateAppId(appIds, authData) {
function validateAppId() {
return Promise.resolve();
}

Expand Down Expand Up @@ -42,11 +42,11 @@ function graphRequest(access_token) {
data = JSON.parse(data);
resolve(data);
});
res.on('error', function (err) {
res.on('error', function () {
reject('Failed to validate this access token with weibo.');
});
});
req.on('error', function (e){
req.on('error', function () {
reject('Failed to validate this access token with weibo.');
});
req.write(postData);
Expand Down