Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #935, cleans up authData null keys on login for android crash #978

Merged
merged 1 commit into from
Mar 11, 2016
Merged

Fixes #935, cleans up authData null keys on login for android crash #978

merged 1 commit into from
Mar 11, 2016

Conversation

flovilmart
Copy link
Contributor

No description provided.

@codecov-io
Copy link

Current coverage is 91.45%

Merging #978 into master will increase coverage by +0.03% as of b92646f

@@            master    #978   diff @@
======================================
  Files           73      73       
  Stmts         4384    4390     +6
  Branches       876     879     +3
  Methods          0       0       
======================================
+ Hit           4008    4015     +7
  Partial         10      10       
+ Missed         366     365     -1

Review entire Coverage Diff as of b92646f

Powered by Codecov. Updated on successful CI builds.

drew-gross
drew-gross reviewed Mar 11, 2016
View reviewed changes
src/Routers/UsersRouter.js
@@ -130,6 +143,7 @@ export class UsersRouter extends ClassesRouter {
let create = new RestWrite(req.config, Auth.master(req.config), '_Session', null, sessionData);
return create.execute();
}).then(() => {
console.log(user);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: this

@drew-gross
Copy link
Contributor

Remove the console.log and then LGTM

@flovilmart
Copy link
Contributor Author

We should probably do something in the android SDK as the JS SDK does the cleanup

@flovilmart flovilmart force-pushed the flovilmart.cleanupNullAuthDatakeysOnLogin branch from 5ba7bad to 1ed868b Compare March 11, 2016 16:15
@facebook-github-bot
Copy link

@flovilmart updated the pull request.

flovilmart added a commit that referenced this pull request Mar 11, 2016
@flovilmart
Merge pull request #978 from ParsePlatform/flovilmart.cleanupNullAuth…
cd7a4b8 
…DatakeysOnLogin

Fixes #935, cleans up authData null keys on login for android crash
@flovilmart flovilmart merged commit cd7a4b8 into master Mar 11, 2016
@flovilmart flovilmart deleted the flovilmart.cleanupNullAuthDatakeysOnLogin branch March 11, 2016 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@flovilmart @codecov-io @drew-gross @facebook-github-bot @yuzeh