Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary Optionals, IUOs, and the like from Event #88

Merged
merged 8 commits into from
Aug 14, 2023
Merged

Remove unnecessary Optionals, IUOs, and the like from Event #88

merged 8 commits into from
Aug 14, 2023

Commits on Aug 10, 2023

  1. Update RequestBuilderTests to account for versions n. with patch 

    E.g. Xcode 14.3.1 would have failed before
    @mokagio
    mokagio committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    787819d View commit details
    Browse the repository at this point in the history

  2. Remove unnecessary internal and var for some Event properties 

    The idea is to reduce the surface area for things to change so that
runtime problems are less likely to arise.
    @mokagio
    mokagio committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    b081ef6 View commit details
    Browse the repository at this point in the history

  3. Remove unnecessary implicitly unwrapped Optional from Event 

    The idea is to reduce the surface area for things to change so that
runtime problems are less likely to arise.
    @mokagio
    mokagio committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    17322dc View commit details
    Browse the repository at this point in the history

  4. Remove unnecessary data property from Event

    @mokagio
    mokagio committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    dd92cf4 View commit details
    Browse the repository at this point in the history

  5. Remove Optional wrapper from Event extra_data 

    The idea is to reduce the surface area for things to change so that
runtime problems are less likely to arise.
    @mokagio
    mokagio committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    b4cf5a3 View commit details
    Browse the repository at this point in the history

  6. Remove an unnecessary force cast from Event

    @mokagio
    mokagio committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    187f606 View commit details
    Browse the repository at this point in the history

  7. Replace an if != nil + force unwrap with if let in Event

    @mokagio
    mokagio committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    5e038c1 View commit details
    Browse the repository at this point in the history

  8. Nitpick: Use guard for an early return in Event

    @mokagio
    mokagio committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    f3e7a85 View commit details
    Browse the repository at this point in the history