Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce binary compatibility validator #101

Merged
merged 15 commits into from
Jan 30, 2024

Conversation

wzieba
Copy link
Collaborator

@wzieba wzieba commented Dec 14, 2023

Description

This PR introduces a binary compatibility validator to help reduce risks of introducing unwanted public API change.

How to test

Please add or remove a public method from any class and then run apiCheck task. It should fail.

@wzieba wzieba marked this pull request as ready for review January 11, 2024 12:56
Copy link

codecov bot commented Jan 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (222b14b) 69.30% compared to head (c9bbd37) 69.30%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #101   +/-   ##
=======================================
  Coverage   69.30%   69.30%           
=======================================
  Files          21       21           
  Lines         404      404           
  Branches       49       49           
=======================================
  Hits          280      280           
  Misses        110      110           
  Partials       14       14           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from issue/parsely_tracker_kotlin_migration to main January 17, 2024 18:07
@wzieba wzieba changed the base branch from main to improve_singleton_handling January 23, 2024 16:46
Base automatically changed from improve_singleton_handling to main January 29, 2024 14:09
@wzieba
Copy link
Collaborator Author

wzieba commented Jan 30, 2024

This PR introduces a development tool. It doesn't affect SDK consumers. I'll merge this without review as it's not dangerous in any way.

@wzieba wzieba merged commit 12607a9 into main Jan 30, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant